Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@hippy/react-web): fix Image repeatedly triggering onError #3302

Merged
merged 15 commits into from
Jul 17, 2023

Conversation

tomdyqin
Copy link
Contributor

Pre-PR Checklist

  • I added/updated relevant documentation.
  • I followed the Convention Commit guideline with maximum 72 characters to submit commit message.
  • I squashed the repeated code commits.
  • I signed the [CLA].
  • I added/updated test cases to check the change I am making.
  • All existing and new tests are passing.

@github-actions github-actions bot added driver: js size: xs Denotes a PR that changes 0-9 lines labels Jun 16, 2023
@hippy-service
Copy link

hippy-service bot commented Jun 16, 2023

Hi, @tomdyqin. Thanks for your PR! 👏

🏷️ You can leave a comment in this PR with #help tag when you need help (e.g. some status checks run failed due to internal issue), admin team members will help asap.

@hippy-service
Copy link

hippy-service bot commented Jun 16, 2023

After a quick scan, I have approved workflow to run.

🏷️ New commits in this PR would not be tested automatically until this pull request is reviewed by our collaborators.
🏷️ No need to worry about the status of merge_guard and [gh] pull request merge guard / merge_guard (pull_request_target) checks, once this pull request is met merge requirements, it will be automatically converted to successful status.

@hippy-service
Copy link

hippy-service bot commented Jun 28, 2023

🎉 It seems that this pull request has been approved by all required reviewers. As it only contains one normal commit, I will rebase and merge it automatically via add action(rebase-merge) label.

@hippy-service hippy-service bot added the action(rebase-merge) Rebase and merge action (maybe privileged) label Jun 28, 2023
@hippy-actions hippy-actions bot enabled auto-merge (rebase) June 28, 2023 07:33
@hippy-actions hippy-actions bot removed the action(rebase-merge) Rebase and merge action (maybe privileged) label Jun 28, 2023
@hippy-actions hippy-actions bot merged commit 68727ac into Tencent:master Jul 17, 2023
16 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
driver: js size: xs Denotes a PR that changes 0-9 lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants