Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(android): make animator work on both enter and exit #3287

Merged
merged 14 commits into from
Jun 28, 2023
Merged

feat(android): make animator work on both enter and exit #3287

merged 14 commits into from
Jun 28, 2023

Conversation

iPel
Copy link
Collaborator

@iPel iPel commented Jun 9, 2023

(cherry-picked from commit 2659871)

Pre-PR Checklist

  • I added/updated relevant documentation.
  • I followed the Convention Commit guideline with maximum 72 characters to submit commit message.
  • I squashed the repeated code commits.
  • I signed the [CLA].
  • I added/updated test cases to check the change I am making.
  • All existing and new tests are passing.

@iPel iPel requested a review from siguangli as a code owner June 9, 2023 09:43
@hippy-service
Copy link

hippy-service bot commented Jun 9, 2023

Hi, @iPel. Thanks for your PR! 👏

🏷️ You can leave a comment in this PR with #help tag when you need help (e.g. some status checks run failed due to internal issue), admin team members will help asap.

@github-actions github-actions bot added the size: m Denotes a PR that changes 100-499 lines label Jun 9, 2023
@hippy-service
Copy link

hippy-service bot commented Jun 20, 2023

🎉 It seems that this pull request has been approved by all required reviewers. As it only contains one normal commit, I will rebase and merge it automatically via add action(rebase-merge) label.

@hippy-service hippy-service bot added the action(rebase-merge) Rebase and merge action (maybe privileged) label Jun 20, 2023
@hippy-actions hippy-actions bot enabled auto-merge (rebase) June 20, 2023 02:38
@hippy-actions hippy-actions bot removed the action(rebase-merge) Rebase and merge action (maybe privileged) label Jun 20, 2023
@zealotchen0 zealotchen0 merged commit 4d1cd4e into Tencent:v3.0-dev Jun 28, 2023
22 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siguangli siguangli siguangli approved these changes

Assignees
No one assigned
Labels
renderer: native size: m Denotes a PR that changes 100-499 lines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@iPel @siguangli @zealotchen0 @open-hippy