Improvements #1
Open
Improvements #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New gems required by the development environment: * rdoc * rspec Updates the Rakefile: * get rid of deprecation warning raised by old rdoc directive * provide a task that runs all the specs * rake default task runs the unit tests.
Ensure nil is returned when the queue is empty and pop is called.
* Use a BSON::OrderedHash to express sort constrain, otherwise sort criteria won't work as expected with ruby 1.8.7 * Extend unit test to cover the different pop scenarios.
Ensure peek respects priority and insertion order.
Test timeout feature inside of pop and peek. Do not use sleep, rely on Timecop: it makes the testing code faster and it's more flexible.
It's totally useless to keep them under scm.
When the timeout feature is disabled the body of the popped item was nil.
Added the following features: * allow to set the priority to a custom value * allow to increase the priority by a custom step * allow to decrease the priority by a custom step All these methods have been implemented using findandmodify in conjunction with '$set' and '$inc' update operators. This provides better performances. Extended the test suite.
This change is inconsistent with mongo_dequeue's api. Item's body cannot be used to perform searches since it can be a really complex object. Dequeue always returns and uses item's _id. This reverts commit a71c172.
This change is inconsistent with mongo_dequeue's api. Item's body cannot be used to perform searches since it can be a really complex object. Dequeue always returns and uses item's _id. This reverts commit 8b7a469.
…emspec [Review] Request from 'jordimassaguerpla' @ 'openSUSE/Dequeue/review_120221_update_version_in_gemspec'
…s_from_gemspec_file [Review] Request from 'jordimassaguerpla' @ 'openSUSE/Dequeue/review_120221_remove_pkg_gem_files_from_gemspec_file'
While processing crowded queues with multiple processes we noticed big slow downs caused by the lack of indexes. This fixes the problem.
Fix the lock_until feature and update the test suite
A more elaborate spec has been pushed earlier.
Ensure peek respects the locked_till attribute like pop does.
Set the locked_at attribute when an item is popped from the list.
Rely on the @collection variable.
get version from VERSION file on the gemspec. Otherwise, when running "gem build" the package has the wrong version.
…pec_ [Review] Request from 'jordimassaguerpla' @ 'openSUSE/Dequeue/review_121029_fix_version_in_gemspec_'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made a couple of changes: