Fix a crash which happens when user shakes the phone #ANDROID-15102

[juangardi21]

🥅 What's the goal?

Fix a crash which happens when user shakes the phone, tweaks activity is shown, goes back and then shakes again.

🚧 How do we do it?

• Ensure navigation happens when the state is in the proper lifecycle: Instead of calling navigate directly from the shake detector, check the NavController state to make sure it's ready to navigate.
• Use a lifecycle-aware state: Try handling navigation in response to a state within the Composable flow, rather than inside LaunchedEffect
• Create new function to not depends on NavController

📘 Documentation changes?

• README updated

🧪 How can I test this?

• Before:

4_5985619573649446339.mp4

• After:

4_5985619573649446337.mp4

[jdelga]

This feature depends on a NavController, although in some cases we might not have a NavController.

In B2P we have this launched effect that does not depend on it, and also allows a custom action to launch the tweaks:

https://github.com/Telefonica/b2p-germany-android/blob/4a9f90436777833358e891f4864d75ad9308309e/app/src/debug/java/com/telefonica/germany/b2p/core/tweaks/ShakeDetectorWrapper.kt#L18

I think this approach would be very helpful to open tweaks from the command line into a different activity (same as SmartWifi does)

[juangardi21]

I've created another function which does not depends on navcontroller

[jdelga]

Cool! Thanks!

[jdelga]

You can set this as default value for onOpenTweaks and leave only one method

[juangardi21]

I don't think I can, because navigate is callable only within the NavController scope

[jdelga]

Ok I see, one method depends on the NavController and the other one doesn't

[DevPabloGarcia]

Nice catch!