Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Tag): remove workaround for background of inactive tag over alternative background #1271

Closed
wants to merge 1 commit into from

Conversation

marcoskolodny
Copy link
Collaborator

Issue: Link

Copy link

Size stats

master this branch diff
Total JS 12.1 MB 12.1 MB -175 B
JS without icons 1.94 MB 1.94 MB -175 B
Lib overhead 68.2 kB 68.2 kB 0 B
Lib overhead (gzip) 16.6 kB 16.6 kB 0 B

Copy link

Accessibility report
✔️ No issues found

ℹ️ You can run this locally by executing yarn audit-accessibility.

@marcoskolodny marcoskolodny marked this pull request as draft October 18, 2024 13:03
Copy link

Deploy preview for mistica-web ready!

✅ Preview
https://mistica-k832g637p-flows-projects-65bb050e.vercel.app

Built with commit 7523644.
This pull request is being automatically deployed with vercel-action

Copy link

Screenshot tests report

private-skin-components / components-in-blau-alternative-4
private-skin-components / components-in-movistar-alternative-4
private-skin-components / components-in-o-2-alternative-4
private-skin-components / components-in-o-2-new-alternative-4
private-skin-components / components-in-telefonica-alternative-4
private-skin-components / components-in-tu-alternative-4
private-skin-components / components-in-vivo-new-alternative-4
theme-variant / theme-variant-alternative
theme-variant / theme-variant-in-dark-mode-alternative

@marcoskolodny
Copy link
Collaborator Author

After reviewing with design team, the tokens for the inactive tag are problematic over alternative background. They will review this and come back to us with a solution when they find one.

@marcoskolodny marcoskolodny deleted the WEB-1803-remove-tag-alternative-logic branch October 18, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant