-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Rows, Cards, FeedbackScreen, FormFields, Buttons): add test ids for components and their internal elements #1270
base: master
Are you sure you want to change the base?
Conversation
Size stats
|
Accessibility report ℹ️ You can run this locally by executing |
Deploy preview for mistica-web ready! ✅ Preview Built with commit 6650b2b. |
Screenshot tests report ✔️ All passing |
@@ -90,6 +90,7 @@ export const InternalBoxed = React.forwardRef<HTMLDivElement, Props & InternalPr | |||
ref | |||
) => { | |||
const isInverseOutside = useIsInverseOrMediaVariant(); | |||
const isInverseInside = isInverse || variant === 'inverse' || variant === 'media'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unrelated, but Boxed was not working properly when using media variant
ref={ref} | ||
className={styles.touchableContainer} | ||
aspectRatio={aspectRatio} | ||
aria-label={isTouchable ? undefined : ariaLabelProp} | ||
> | ||
<Boxed className={styles.boxed} isInverse={isInverse} width="100%" minHeight="100%"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unrelated, but I saw this usages of deprecated isInverse prop and updated them in order to use variant instead
@@ -74,7 +74,7 @@ export const Default: StoryComponent<Args> = ({forceNonCssAspectRatio}) => { | |||
); | |||
|
|||
return ( | |||
<Stack space={16} dataAttributes={{testId: 'story'}}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unrelated, but camelCase is not correct here
Issue: Link