Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(PhoneNumberField): Revert lazy load of libphonenumber #1258

Merged
merged 2 commits into from
Oct 3, 2024
Merged

fix(PhoneNumberField): Revert lazy load of libphonenumber #1258

merged 2 commits into from
Oct 3, 2024

Conversation

pladaria
Copy link
Member

@pladaria pladaria commented Oct 3, 2024

Reverts #1244 because several issues have been detected

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 3, 2024

Size stats

master this branch diff
Total JS 12.2 MB 12.2 MB -1.34 kB
JS without icons 2.02 MB 2.02 MB -1.34 kB
Lib overhead 68.3 kB 68.3 kB 0 B
Lib overhead (gzip) 16.6 kB 16.6 kB 0 B

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 3, 2024 •
edited
Loading

Accessibility report
✔️ No issues found

ℹ️ You can run this locally by executing yarn audit-accessibility.

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 3, 2024 •
edited
Loading

Deploy preview for mistica-web ready!

✅ Preview
https://mistica-lkm4xqmoi-flows-projects-65bb050e.vercel.app

Built with commit 7d81f3b.
This pull request is being automatically deployed with vercel-action

@pladaria pladaria added this pull request to the merge queue Oct 3, 2024
Merged via the queue into master with commit 3d18271 Oct 3, 2024
11 checks passed
@pladaria pladaria deleted the revert-1244-pladaria/WEB-2029_async-libphonenumber branch October 3, 2024 15:45
tuentisre pushed a commit that referenced this pull request Oct 3, 2024
@semantic-release-bot
chore(release): 16.1.1 [skip ci]
260732c 
## [16.1.1](v16.1.0...v16.1.1) (2024-10-03)

### Bug Fixes

* **PhoneNumberField:** Revert lazy load of libphonenumber ([#1258](#1258)) ([3d18271](3d18271)), closes [#1244](#1244)
* **Sheet:** avoid content from rendering on top of sticky title/buttons ([#1247](#1247)) ([21ce399](21ce399))
@tuentisre
Copy link
Collaborator

🎉 This PR is included in version 16.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atabel atabel atabel approved these changes

@marcoskolodny marcoskolodny marcoskolodny approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pladaria @tuentisre @atabel @marcoskolodny