Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IOS-10545 Fix warnings in XCode 16 #400

Merged
merged 3 commits into from
Oct 3, 2024

Conversation

alejandroruizponce
Copy link
Contributor

🎟️ Jira ticket

https://jira.tid.es/browse/IOS-10545

πŸ₯… What's the goal?

With the release of XCode 16 and Swift 6, new warnings have emerged that can be fixed along with old ones.

🚧 How do we do it?

The following changes have been made:

  • AppCenter framework has been updated to its latest version due to an error in finding an AppCenterDistribute .h file.
  • Lottie framework has also been updated as its git address had been changed and it could not find the repository.
  • In Swift 6 a new warning has appeared in those modules that conform types like Identifiable, Hashable... in an external way to the module, this can cause that if the module evolves in the future and includes this type there can be conflicts in the code that give error. More information here:
    https://github.com/swiftlang/swift-evolution/blob/main/proposals/0364-retroactive-conformance-warning.md

The solution* is backward-compatible with previous versions of XCode by fully-qualifying all types in the extension. As an example, the above conformance can also be written as

extension Foundation.Date: Swift.Identifiable {
    // ...
}

* Another solution that we could perhaps consider in the future would be to wrap the modules that we want to conform those types to avoid doing it in the native modules.

@alejandroruizponce alejandroruizponce merged commit 27adcbd into main Oct 3, 2024
2 checks passed
@alejandroruizponce alejandroruizponce deleted the IOS-10545-XCode-16-changes branch October 3, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants