Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tokens #396

Merged
merged 5 commits into from
Aug 26, 2024
Merged

Update tokens #396

merged 5 commits into from
Aug 26, 2024

Conversation

amegias
Copy link
Contributor

@amegias amegias commented Aug 21, 2024

🎟️ Jira ticket

https://jira.tid.es/browse/IOS-10491

πŸ₯… What's the goal?

Taking advantage of #397 which needs to release breaking changes, I've updated the tokens which, some of them, have been renamed (Selected -> Pressed) + added title3 font size needed in that PR.

🚧 How do we do it?

πŸͺ„ make skin πŸͺ„

πŸ§ͺ How can I verify this?

  • As you can see, tests still pass so nothing should be changed.
  • The breaking changes are in this commit f45624f
    Since the color tokens are public, we will do something similar in each project (breaking changes)

@amegias amegias marked this pull request as ready for review August 22, 2024 15:48
Copy link
Contributor

@yceballost yceballost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ§‘β€πŸ³πŸ’‹

Copy link
Contributor

@alejandroruizponce alejandroruizponce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks

* Update Title styles

* Fix current screenshots

* Add tests for new title styles

* Add new title styles to the catalog

* Keep the previous one as default to avoid breaking changes
Copy link

github-actions bot commented Aug 23, 2024

Screenshot tests report

βœ”οΈ All passing

@amegias amegias merged commit d3df994 into main Aug 26, 2024
2 checks passed
@amegias amegias deleted the update-titles branch August 26, 2024 15:21
tuentisre pushed a commit that referenced this pull request Aug 26, 2024
# [33.0.0](v32.0.0...v33.0.0) (2024-08-26)

### Feat

* **Title:** Update title component and Mistica tokens ([#396](#396)) ([d3df994](d3df994)), closes [#397](#397)

### BREAKING CHANGES

* **Title:** Add some title styles and modify the existing ones. Rename the color tokens from mistica-design.

* Update tokens

* Update tokens again

* Fix breaking change
@tuentisre
Copy link
Collaborator

πŸŽ‰ This PR is included in version 33.0.0 πŸŽ‰

The release is available on GitHub release

Your semantic-release bot πŸ“¦πŸš€

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants