Title stack #395
Title stack #395
Conversation
|
|
||
| import UIKit | ||
|
|
||
| public class TitleHeaderFooterView: UITableViewHeaderFooterView { |
There was a problem hiding this comment.
the original component. It inherits from UITableViewHeaderFooterView but we need a UIView.
We expose this TitleHeaderFooterView which is a wrap of a TitleView inheriting from UITableViewHeaderFooterView
| let style = Constants.styles[section] | ||
| headerView.title = style.title | ||
| headerView.style = style.titleStyle | ||
| headerView.linkTitle = style.linkTitle | ||
| headerView.onLinkLabelTapped = { | ||
| print("onLinkLabelTapped") |
There was a problem hiding this comment.
just to verify it's not broken
| @@ -15,7 +15,7 @@ private enum ViewStyles { | |||
| static let minimumHeight: CGFloat = 40 | |||
| } | |||
|
|
|||
| public class TitleView: UITableViewHeaderFooterView { | |||
| public class TitleView: UIView { | |||
| @@ -139,6 +132,7 @@ private extension TitleView { | |||
| func layoutViews() { | |||
| linkLabel.setContentHuggingPriority(.required, for: .horizontal) | |||
| linkLabel.setContentCompressionResistancePriority(.required, for: .horizontal) | |||
| linkLabel.isUserInteractionEnabled = true | |||
There was a problem hiding this comment.
the link didn't work!!!!!!
I don't know if it's already broken in SW/iphoneapp (where it's being used)
There was a problem hiding this comment.
I guess that if it is working for them it is because they are using
titleView.isUserInteractionEnabled = true
titleView.addGestureRecognizer(UITapGestureRecognizer(target: self, action: #selector(linkLabelTapped)))
directly on the TitleView instance.
|
|
||
| import UIKit | ||
|
|
||
| public class TitleHeaderFooterView: UITableViewHeaderFooterView { |
There was a problem hiding this comment.
I know it's a breaking change but I think it should be....
Do you prefer keeping TitleView and call the internal view something like... TitleStack?? IMO it's worse but let me know.
I found occurrences in SmartWifi and iphoneapp, but it should be super easy to resolve them.
There was a problem hiding this comment.
IMHO I prefer the breaking change and fix in the project, should be no problem
There was a problem hiding this comment.
I rather prefer the breaking change too.This won't be to difficult to update.
|
|
||
| private lazy var titleView = TitleView() | ||
|
|
||
| public var onLinkLabelTapped: (() -> Void)? { |
There was a problem hiding this comment.
the get first and more consise version :
public var onLinkLabelTapped: (() -> Void)? {
get { titleView.onLinkLabelTapped }
set { titleView.onLinkLabelTapped = newValue }
}
# [32.0.0](v31.4.1...v32.0.0) (2024-08-19) ### Features * **Title:** Split Title component and UIKit ([#395](#395)) ([161ac6d](161ac6d)) ### BREAKING CHANGES * **Title:** Rename TitleView with TitleHeaderFooterView. TitleHeaderFooterView will wrap the TitleView (Title component) * Enable link interactions * Extract Title component from TitleView (UITableViewHeaderFooterView) * Rename and some fixes * Rename tests path * CR changes
|
🎉 This PR is included in version 32.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
🎟️ Jira ticket
https://jira.tid.es/browse/IOS-10494
🥅 What's the goal?
We are going to work on https://jira.tid.es/browse/IOS-10327 where we refactor the UI of the soft/hard update feature.
Now, it needs the
TitleViewcomponent but we implemented it as aUITableViewHeaderFooterView.We need to split it.
https://www.figma.com/design/xNUwhH29z3Fre4foNltgtX/Novum_Specs?node-id=15589-86732
🚧 How do we do it?
I've extracted the internal view to
TitleViewand rename the current one (which is aUITableViewHeaderFooterView) toTitleHeaderFooterView.I found some bugs that I will mention in the code
🧪 How can I verify this?
title.mov