IOS-10430 fix padding #393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Screenshot tests report ✔️ All passing |
|
Record screenshots on PR comment: succeeded ✅ |
|
Record screenshots on PR comment: succeeded ✅ |
yceballost
requested changes
Jul 26, 2024
| @@ -223,7 +223,7 @@ public class FeedbackView: UIView { | |||
| private lazy var scrollStackView: ScrollStackView = { | |||
| let scrollStackView = ScrollStackView(arrangedSubviews: [contentContainerStackView]) | |||
| scrollStackView.translatesAutoresizingMaskIntoConstraints = false | |||
| scrollStackView.stackView.spacing = 24 | |||
| scrollStackView.stackView.spacing = 16 | |||
There was a problem hiding this comment.
This spacing should keep it in 24 (the space between icon and title in feedbacks)
|
Record screenshots on PR comment: succeeded ✅ |
alexanegon
approved these changes
Jul 29, 2024
amegias
approved these changes
Jul 29, 2024
|
🎉 This PR is included in version 31.4.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Jira ticket
https://jira.tid.es/browse/IOS-10430
🥅 What's the goal?
Review Mistica/iphoneapp to check if there is any padding=24(horizontal) replacing with 16.
🧪 How can I verify this?
Check new screenshots for test.
🏑 AppCenter build
https://install.appcenter.ms/orgs/tuenti-organization/apps/mistica-swiftui-ios/distribution_groups/public
Version 31.3.0 (1)