Ios 10314-include custom fonts in mistica catalog app #376
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,90 @@ | ||
| // | ||
| // BrandStyle+FontMapping.swift | ||
| // | ||
| // Made with ❤️ by Novum | ||
| // | ||
| // Copyright © Telefonica. All rights reserved. | ||
| // | ||
|
|
||
| import Mistica | ||
| import SwiftUI | ||
| import UIKit | ||
|
|
||
| extension BrandStyle { | ||
| // A computed property that returns the corresponding FontMapping for the brand style. | ||
| var fontMapping: FontMapping? { | ||
| switch self { | ||
| case .vivoNew: | ||
| return FontMapping( | ||
| lightFont: "VivoType-Light", | ||
| mediumFont: "VivoType-Bold", | ||
| boldFont: "VivoType-Bold", | ||
| defaultFont: "VivoType-Regular" | ||
| ) | ||
| case .o2, .o2New, .movistar: | ||
| return FontMapping( | ||
| lightFont: "OnAir-Light", | ||
| mediumFont: "OnAir", | ||
| boldFont: "OnAir-Bold", | ||
|
There was a problem hiding this comment. Isn't this |
||
| defaultFont: "OnAir-Regular" | ||
| ) | ||
|
|
||
| case .telefonica, .tu: | ||
| return FontMapping( | ||
| lightFont: "Telefonica Sans Light", | ||
| mediumFont: "Telefonica Sans Bold", | ||
| boldFont: "Telefonica Sans Bold", | ||
| defaultFont: "Telefonica Sans Regular" | ||
| ) | ||
|
|
||
| case .vivo, .blau, .custom: | ||
| return nil | ||
| } | ||
| } | ||
| } | ||
|
|
||
| // A struct representing a mapping of font names to different font weights. | ||
| struct FontMapping { | ||
| let lightFont: String | ||
| let mediumFont: String | ||
| let boldFont: String | ||
| let defaultFont: String | ||
|
|
||
| /** | ||
| Returns the font name for the specified weight. | ||
|
|
||
| - Parameter weight: The `Font.Weight` for which to get the font name. | ||
| - Returns: The font name corresponding to the given weight. | ||
| */ | ||
| func fontName(for weight: Font.Weight) -> String { | ||
| switch weight { | ||
| case .light, .ultraLight, .thin: | ||
| return lightFont | ||
| case .medium: | ||
| return mediumFont | ||
| case .bold, .semibold, .black, .heavy: | ||
| return boldFont | ||
| default: | ||
| return defaultFont | ||
| } | ||
| } | ||
|
|
||
| /** | ||
| Returns the font name for the specified weight. | ||
|
|
||
| - Parameter weight: The `UIFont.Weight` for which to get the font name. | ||
| - Returns: The font name corresponding to the given weight. | ||
| */ | ||
| func UIfontName(for weight: UIFont.Weight) -> String { | ||
| switch weight { | ||
| case .light, .ultraLight, .thin: | ||
| return lightFont | ||
| case .medium: | ||
| return mediumFont | ||
| case .bold, .semibold, .black, .heavy: | ||
| return boldFont | ||
| default: | ||
| return defaultFont | ||
| } | ||
| } | ||
| } | ||
yceballost marked this conversation as resolved.
Show resolved
Hide resolved
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, use DemiBold instead of Bold font weight
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I followed the documentation from Mistica's readme for the implementation of the Telefonica font.
https://github.com/Telefonica/mistica-ios/tree/main/Sources/MisticaCommon/Fonts
However, the brand documentation indicates, as you mentioned, using DemiBold, but it also indicates using Medium. In which cases should I choose the different font types?
https://brandfactory.telefonica.com/document/483#/nuestra-identidad-visual/tipografia
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done, updated
https://install.appcenter.ms/orgs/tuenti-organization/apps/mistica-swiftui-ios/distribution_groups/public