Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LATCH-1002 Update text weight for Tag component #314

Closed
wants to merge 1 commit into from

Conversation

jaranaz
Copy link
Contributor

@jaranaz jaranaz commented Oct 16, 2023

🎟️ Jira ticket

https://jira.tid.es/browse/LATCH-1002

πŸ₯… What's the goal?

According to Tag specs documentation, the component must apply the text weight named .medium, instead of .indicator

🚧 How do we do it?

Update Tag component in SwiftUI and UIKit to use .medium text weight

πŸ‘ AppCenter build

qrcode (2)

@jaranaz jaranaz self-assigned this Oct 16, 2023
@jaranaz jaranaz requested review from a team, idenjoe and alexanegon and removed request for a team October 16, 2023 15:16
@aweell
Copy link

aweell commented Oct 17, 2023

Hi @jaranaz

The text weight indicator is correct since the weight of the tag label for vivo-new skin should be regular instead of medium. You can check the weight token definitions in: https://www.figma.com/file/PApssATUkePZnIOB4GmAeI?node-id=2190:1642&locale=en&type=design

The specs are outdated and will be corrected.

@idenjoe
Copy link
Contributor

idenjoe commented Oct 17, 2023

These specs are not up to date. We made some changes from this figma a few months ago to fit the new vivo typography (it has not medium typography) in Mistica. We should not use medium weight directly in any ui component in Mistica. Instead we should use tokens from MisticaFontWeights that are matched for every brand to the corresponding weight(in case of VivoNewFontWeight you can see that none of them matches medium weight)

@jaranaz jaranaz closed this Oct 17, 2023
@jaranaz
Copy link
Contributor Author

jaranaz commented Oct 17, 2023

PR declined due to the right style to use is .indicator
Tag specs are not updated with some last changes in Mistica iOS library.

@jaranaz jaranaz deleted the LATCH-1002-fix-tag-text-color branch October 25, 2023 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants