-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LATCH-1000: fix Button disabled state #310
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
π
29dc4f2
to
1c53613
Compare
@@ -43,8 +43,8 @@ public extension ButtonStyle where Self == MisticaButtonStyle { | |||
), | |||
.disabled: MisticaButton.StateStyle( | |||
textColor: .textButtonPrimary, | |||
backgroundColor: .buttonPrimaryBackground, | |||
borderColor: .buttonPrimaryBackground | |||
backgroundColor: .buttonPrimaryBackground.opacity(0.5), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMHO I would use constants for these opacities since they are repeated in many places.
700bd4c
to
99ea66f
Compare
99ea66f
to
b92c215
Compare
# [26.2.0](v26.1.0...v26.2.0) (2023-10-16) ### Bug Fixes * **Button:** change colors for disabled style ([#308](#308)) ([e829160](e829160)) * **Button:** change colors for disabled style ([#310](#310)) ([fb108a1](fb108a1)) * **Button:** Change cornerCurve from continuous to circular ([#307](#307)) ([26a73b3](26a73b3)) * **Snackbar:** change color for action button ([#304](#304)) ([7054e3d](7054e3d)) * **Tag:** change foreground and background colors according to specs ([#309](#309)) ([6a9f441](6a9f441)) ### Features * **Button:** Added accesibility to right image (chevron) ([05d77d9](05d77d9))
π This PR is included in version 26.2.0 π The release is available on GitHub release Your semantic-release bot π¦π |
ποΈ Jira ticket
https://jira.tid.es/browse/LATCH-1000
π₯ What's the goal?
The
Button
component for SwiftUI is using wrong colors for its disabled state.This PR completes the already merged PR #308, where some states were missed.
π AppCenter build