Ios 9244 button link accesibility #305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Screenshot tests report ✔️ All passing |
alexanegon
force-pushed
the
IOS-9244-ButtonLink-accesibility
branch
from
d05240d
to
719f2e3
Compare
amegias
reviewed
Sep 25, 2023
Comment on lines
+58
to
+63
| .padding(.vertical, verticalPadding) | ||
| .padding(.horizontal, horizontalPadding) | ||
| .background(backgroundColor) | ||
| .foregroundColor(foregroundColor) | ||
| .border(radiusStyle: .button, borderColor: borderColor) | ||
| .padding(EdgeInsets(top: 0, leading: leadingInset, bottom: 0, trailing: trailingInset)) |
There was a problem hiding this comment.
those lines don't depend on the scale, could we put in common with the other approach?
There was a problem hiding this comment.
That was the my first approach but they modify the button layout and breaks the tests :(
amegias
approved these changes
Sep 25, 2023
WanaldinoTelefonica
approved these changes
Sep 25, 2023
|
🎉 This PR is included in version 26.2.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Jira ticket
IOS-9244
🥅 What's the goal?
We must enable that the right image of the
MisticaButtonfollows the accesibility property🚧 How do we do it?
We have a new property wrapper in iOS 14 called
ScaledMetricit is to define numbers that should scale automatically according to the user’s Dynamic Type settings.To use it due to support iOS 13 we have to create a new struct not available prior to iOS 14 called
ScaledMisticaButtonwhich receives a content, height and width in its init to keep the functionality of the old modifiers and extend them with the scale🧪 How can I verify this?
Accesibility.mov