Ios 9080 button chevron #294
Conversation
WanaldinoTelefonica
requested review from
Gomay88 and
alexanegon
and removed request for
a team
|
Screenshot tests report ✔️ All passing |
|
please add @mistica-design as a reviewer :) |
WanaldinoTelefonica
requested review from
a team,
aweell,
DavidMarinCalleja and
amegias
and removed request for
a team,
Gomay88 and
alexanegon
|
When the link isLoading, is the chevron hidden? |
| private var _image: UIImage { | ||
| switch self { | ||
| case .chevron: return .chevron | ||
| case let .custom(image: image): return image | ||
| } | ||
| } | ||
|
|
||
| var image: UIImage { | ||
| _image.withRenderingMode(.alwaysTemplate) | ||
| } |
There was a problem hiding this comment.
Why have image: UIImage and _image: UIImage?
| private var _image: UIImage { | |
| switch self { | |
| case .chevron: return .chevron | |
| case let .custom(image: image): return image | |
| } | |
| } | |
| var image: UIImage { | |
| _image.withRenderingMode(.alwaysTemplate) | |
| } | |
| var image: UIImage { | |
| switch self { | |
| case .chevron: | |
| return .chevron.withRenderingMode(.alwaysTemplate) | |
| case let .custom(image: image): | |
| return image.withRenderingMode(.alwaysTemplate) | |
| } | |
| } |
There was a problem hiding this comment.
The point is that the image should have the same color as the title, so it should be rendered as a template to be tinted. The idea is that I didn't want to set all the image cases with .withRenderingMode(.alwaysTemplate). The private _image is the image itself and the published property image is which sets the property
| return imageView | ||
| }() | ||
|
|
||
| private lazy var rightImageHeightConstraint: NSLayoutConstraint = rightImageView.heightAnchor.constraint(equalToConstant: 1) |
There was a problem hiding this comment.
because the value of the constant is 1
There was a problem hiding this comment.
It is just an arbitrary value for the definition of the constraint
Yes, AFAIK the chevron only shown on the right of the main title, not on loading |
There was a problem hiding this comment.
I see the right and the left alignment, in order to anticipate future evolutions, does it make sense to add the vertical bleeding alignment in this PR? When the buttonLink goes into a title, the size of the button container is making the title container to be bigger than it should be, that's why the need of this property. https://jira.tid.es/browse/IOS-9201
I think this should only target adding the chevron for creating the new bottomsheet functionality
Yes, we know but it was deprioritized. If there is time before the release we have this task to add it https://jira.tid.es/browse/IOS-9244 |
* fix(Button): Fix full width * fix(Button): Update tests * fix(Button): Fix center view * record failing tests of the first brand * record failing tests of the other brands --------- Co-authored-by: Alejandro Megías <[email protected]>
|
🎉 This PR is included in version 26.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
🎟️ Jira ticket
IOS-9080
🥅 What's the goal?
🚧 How do we do it?
For UIKit define a new property that configures an UIImageView with the corresponding image.
There is an enum with the posible cases with only chevron defined. This could be extended in the future.
For SwiftUI there is a new property
withChevronon theButtonStyleformisticaLinkandmisticaLinkInverse. This will add onMisticaButtonStylethe property.chevrononMisticaButtonforrightImage🧪 How can I verify this?
Check screenshots :D
🏑 AppCenter build
Use last version 25.4.0 (1)
https://install.appcenter.ms/orgs/tuenti-organization/apps/mistica-swiftui-ios/distribution_groups/public/releases/22