-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Bottom Sheet): Fix component to expand horizontally #290
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
@@ -84,13 +82,12 @@ private extension InformativeRow { | |||
bottomContent.isHidden = true | |||
} | |||
|
|||
dummyView.amount = item.icon.size.width | |||
bottomContent.layoutMargins.left = item.icon.size.width + 8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMHO Magic number "8" must be in a descriptive constant because you are using it here and in the frontStackView
WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, I've changed it π
π This PR is included in version 25.3.1 π The release is available on GitHub release Your semantic-release bot π¦π |
ποΈ Jira ticket
IOS-9113
π₯ What's the goal?
π§ How do we do it?
Info: The dot is centered on a single line label with the same specs than the visible label, but is in a deeper layer stackView.
π§ͺ How can I verify this?