Ios 10314-include custom fonts in mistica catalog app #376
Conversation
| return "VivoType-Regular" | ||
| } | ||
| } | ||
| case .o2, .movistar: |
| return "VivoType-Regular" | ||
| } | ||
| } | ||
| case .o2, .movistar: |
| return "OnAir-Regular" | ||
| } | ||
| } | ||
| default: |
There was a problem hiding this comment.
Consider to avoid using default. Then if we add a new brand in the future, it will be forced to put that new brand in some case ;)
| return "OnAir-Regular" | ||
| } | ||
| } | ||
| default: |
There was a problem hiding this comment.
Consider to avoid using default. Then if we add a new brand in the future, it will be forced to put that new brand in some case ;)
L-Trujillo26
requested review from
alejandroruizponce,
dhidalgofadrique and
yceballost
and removed request for
alejandroruizponce
…and added telefonica and tu font
…and added telefonica and tu font
done! |
| return FontMapping( | ||
| lightFont: "OnAir-Light", | ||
| mediumFont: "OnAir", | ||
| boldFont: "OnAir-Bold", |
There was a problem hiding this comment.
Isn't this OnAir-Bold font missing in MisticaCatalog/Resources/ and in the Info.plist UIAppFonts property?
There was a problem hiding this comment.
Please, use DemiBold instead of Bold font weight
There was a problem hiding this comment.
I followed the documentation from Mistica's readme for the implementation of the Telefonica font.
https://github.com/Telefonica/mistica-ios/tree/main/Sources/MisticaCommon/Fonts
However, the brand documentation indicates, as you mentioned, using DemiBold, but it also indicates using Medium. In which cases should I choose the different font types?
https://brandfactory.telefonica.com/document/483#/nuestra-identidad-visual/tipografia
There was a problem hiding this comment.
…onts-in-Mistica-Catalog-app
L-Trujillo26
deleted the
IOS-10314-include-custom-fonts-in-Mistica-Catalog-app
branch
|
🎉 This PR is included in version 31.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
🎟️ Jira ticket
https://jira.tid.es/browse/IOS-10314
🥅 What's the goal?
Include custom fonts (Vivo & OnAir) in Mistica Catalog app.
🚧 How do we do it?
Adding the fonts to the Mystica Catalog app and setting the FontStyle to match the selected brand's font.
🧪 How can I verify this?
The font changes to the selected brand: Vivo New, O2, or Movistar.
🏑 AppCenter build
https://install.appcenter.ms/orgs/tuenti-organization/apps/mistica-swiftui-ios/distribution_groups/public
Mistica Alpha - iOS 30.4.0 (1)