Resource recommendation #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he moments_keywords array
…tags before splitting moment keywords
guialbuk
reviewed
Apr 16, 2020
| @@ -0,0 +1,34 @@ | |||
| describe MomentKeywords do | |||
| subject(:moment) {FactoryBot.build(:moment, | |||
There was a problem hiding this comment.
This must be let as it does not refer to the tested class (MomentKeywords)
Suggested change
| subject(:moment) {FactoryBot.build(:moment, | |
| let(:moment) {FactoryBot.build(:moment, |
Comment on lines
2
to
8
| subject(:moment) {FactoryBot.build(:moment, | ||
| categories: [build(:category, name: 'free', description: 'Description')], | ||
| moods: [build(:mood, name: 'Name', description: 'Blog^^')], | ||
| strategies: [build(:strategy, name: 'Name', description: 'books@!##.')], | ||
| name: "ADDICTION", | ||
| why: "self-care.", | ||
| fix: "@Teachers!!" )} |
There was a problem hiding this comment.
The most accepted style for multiline blocks is using do...end:
Suggested change
| subject(:moment) {FactoryBot.build(:moment, | |
| categories: [build(:category, name: 'free', description: 'Description')], | |
| moods: [build(:mood, name: 'Name', description: 'Blog^^')], | |
| strategies: [build(:strategy, name: 'Name', description: 'books@!##.')], | |
| name: "ADDICTION", | |
| why: "self-care.", | |
| fix: "@Teachers!!" )} | |
| subject(:moment) do | |
| FactoryBot.build( | |
| :moment, | |
| categories: [build(:category, name: 'free', description: 'Description')], | |
| moods: [build(:mood, name: 'Name', description: 'Blog^^')], | |
| strategies: [build(:strategy, name: 'Name', description: 'books@!##.')], | |
| name: "ADDICTION", | |
| why: "self-care.", | |
| fix: "@Teachers!!" | |
| ) | |
| end |
| why: "self-care.", | ||
| fix: "@Teachers!!" )} | ||
|
|
||
| let(:keywords) { MomentKeywords.new(moment).extract_moment_keywords } |
There was a problem hiding this comment.
It it refers to the class being testes (MomentKeywords), this needs to be the subject
Suggested change
| let(:keywords) { MomentKeywords.new(moment).extract_moment_keywords } | |
| subject(:keywords) { MomentKeywords.new(moment).extract_moment_keywords } |
| @@ -0,0 +1,22 @@ | |||
| describe ResourceRecommendation do | |||
| subject(:moment) {FactoryBot.build(:moment, | |||
There was a problem hiding this comment.
Suggested change
| subject(:moment) {FactoryBot.build(:moment, | |
| let(:moment) {FactoryBot.build(:moment, |
| why: 'text', | ||
| fix: 'text' )} | ||
|
|
||
| let(:resources) { ResourceRecommendation.new(moment).resources} |
There was a problem hiding this comment.
Suggested change
| let(:resources) { ResourceRecommendation.new(moment).resources} | |
| subject(:resources) { ResourceRecommendation.new(moment).resources} |
Comment on lines
+30
to
+34
| end | ||
|
|
||
|
|
||
|
|
||
|
|
There was a problem hiding this comment.
These extra empty lines must be removed
|
It looks good! 👍 Almost there |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
More Details
Corresponding Issue
Screenshots
Reviewing this pull request? Check out our Code Review Practices guide if you haven't already!