Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix NPE on LoadFilesListTask#listTrashBinFiles #4224

Merged
merged 3 commits into from
Aug 20, 2024

Conversation

malirauf
Copy link
Contributor

Description

NPE on LoadFilesListTask#listTrashBinFiles

Issue tracker

Fixes #4142

@TeamAmaze TeamAmaze deleted a comment from ZEYER45 Jul 25, 2024
Copy link
Member

@VishnuSanal VishnuSanal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@malirauf thanks for your interest in contributing to Amaze! I've some changes to be done, please see the reviews.

@@ -1863,7 +1863,7 @@ public TrashBinFile toTrashBinRestoreFile(Context context) {
TrashBin trashBin = AppConfig.getInstance().getTrashBinInstance();
for (TrashBinFile trashBinFile : trashBin.listFilesInBin()) {
if (trashBinFile.getDeletedPath(trashBin.getConfig()).equals(path)) {
// finding path to restore to
// finding path to restore tof
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please revert

Copy link
Member

@VishnuSanal VishnuSanal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@VishalNehra VishalNehra merged commit 4612942 into TeamAmaze:release/4.0 Aug 20, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NPE on LoadFilesListTask#listTrashBinFiles
4 participants