Reduce Overdraw on About activity #4222
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VishnuSanal
requested changes
Jul 20, 2024
There was a problem hiding this comment.
@hammadrfq3 thanks for contributing to amaze! your PR looks great; but, there are some minor things to be addressed before this is ready for merging. please take a look at the review comments.
app/src/main/java/com/amaze/filemanager/adapters/LanguageAdapter.java
Outdated
Show resolved
Hide resolved
app/src/main/java/com/amaze/filemanager/models/LanguageModel.java
Outdated
Show resolved
Hide resolved
VishnuSanal
approved these changes
Jul 25, 2024
Thanks |
VishnuSanal
added
the
pr-awaiting-final-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Overdraw issue has been fixed by using constraintLayout instead of Nested Relative and LinearLayouts and also added recyclerview for translation section.
Issue tracker
Fixes #3109
Manual tests