Migrate fingerprint decryption dialog to use AndroidX Biometrics API #4218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TranceLove
added
Area-UIUX
TranceLove
force-pushed
the
feature/biometric-api
branch
3 times, most recently
from
e83433c
to
6c57b18
Compare
TranceLove
force-pushed
the
feature/biometric-api
branch
from
6c57b18
to
67d29ea
Compare
VishalNehra
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per recommendation, remove self built UI with the dialog provided by AndroidX Biometrics API.
Manual tests
Done
Device: Oneplus 2
OS: DivestOS 17.1 (Android 10)
File decryption using fingerprint authentication should not be affected by this change.
Build tasks success
Successfully running following tasks on local:
./gradlew assembledebug./gradlew spotlessCheck