Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

๐Ÿ”— :: (#728) ๊ธฐ์—… ์ด๋ฉ”์ผ ์ •๊ทœ์‹ ํ™•์ธ ์ฝ”๋“œ ์ถ”๊ฐ€ #729

Merged
merged 2 commits into from
Oct 1, 2024
Merged

๐Ÿ”— :: (#728) ๊ธฐ์—… ์ด๋ฉ”์ผ ์ •๊ทœ์‹ ํ™•์ธ ์ฝ”๋“œ ์ถ”๊ฐ€ #729

merged 2 commits into from
Oct 1, 2024

Conversation

4mjeo
Copy link
Member

@4mjeo 4mjeo commented Sep 30, 2024

์ž‘์—… ๋‚ด์šฉ ์„ค๋ช…

  • ๊ธฐ์—… ๋“ฑ๋ก, ์ˆ˜์ • ์‹œ ์ด๋ฉ”์ผ ํ˜•์‹์„ ํ™•์ธํ•˜๋Š” ์ •๊ทœ์‹์„ ์ถ”๊ฐ€ํ–ˆ์Šต๋‹ˆ๋‹ค.
  • ์ •๊ทœ์‹์— ๋งž์ง€ ์•Š์œผ๋ฉด 400์ด ๋ฐ˜ํ™˜๋ฉ๋‹ˆ๋‹ค.
  • ์ •๊ทœ์‹ ์กฐ๊ฑด ^[a-zA-Z0-9+-_.]+@[a-zA-Z0-9-]+.[a-zA-Z0-9-.]+$

๊ฒฐ๊ณผ๋ฌผ(์žˆ์œผ๋ฉด)

์ฒดํฌ๋ฆฌ์ŠคํŠธ

  • ์–ดํ”Œ๋ฆฌ์ผ€์ด์…˜ ๊ตฌ๋™(ํ˜น์€ ํ…Œ์ŠคํŠธ)์‹œ ์˜ค๋ฅ˜๋Š” ์—†๋‚˜์š”?
  • DDL์ด ๋ณ€๊ฒฝ๋˜์—ˆ์„ ๊ฒฝ์šฐ flyway ๋งˆ์ด๊ทธ๋ ˆ์ด์…˜ ์Šคํฌ๋ฆฝํŠธ๋ฅผ ์ž‘์„ฑํ•˜์˜€๋‚˜์š”?
  • ์ƒ์„ฑ๋œ ์ฝ”๋“œ์— ๋Œ€ํ•œ ํ…Œ์ŠคํŠธ ์ฝ”๋“œ๊ฐ€ ์ž‘์„ฑ ๋˜์—ˆ๋‚˜์š”?

๊ด€๋ จ ์ด์Šˆ

@4mjeo 4mjeo self-assigned this Sep 30, 2024
@4mjeo 4mjeo requested a review from a team as a code owner September 30, 2024 13:54
@4mjeo 4mjeo linked an issue Sep 30, 2024 that may be closed by this pull request
ํšŒ์‚ฌ ์ด๋ฉ”์ผ ํ˜•์‹ ํ™•์ธ #728
Closed
@4mjeo
Copy link
Member Author

4mjeo commented Sep 30, 2024

fax๊ฐ’์€ 309๋กœ BadRequest๋ฅผ ์•Œ๋ ค์ฃผ๋Š”๋ฐ ํ†ตํ•ฉํ•˜๋Š”๊ฒŒ ์ข‹์„๊ฑฐ ๊ฐ™์•„์š”

๋„ค?????? 309๋ผ๊ตฌ์š”???? ํ .......

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 30, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@4mjeo 4mjeo merged commit b9c22f8 into develop Oct 1, 2024
3 checks passed
@4mjeo 4mjeo deleted the feat/728-add-company-email-regex branch October 1, 2024 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parkuiery parkuiery parkuiery approved these changes

Assignees

@4mjeo 4mjeo

Labels
๊ธฐ๋Šฅ ์ถ”๊ฐ€
Projects
์Šคํ”„๋ฆฐํŠธ 2๊ธฐ
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ํšŒ์‚ฌ ์ด๋ฉ”์ผ ํ˜•์‹ ํ™•์ธ
2 participants
@4mjeo @parkuiery