Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

프로필 수정 페이지 구현 #70

Merged
merged 3 commits into from
Nov 13, 2023
Merged

Conversation

bomi8489
Copy link
Contributor

@bomi8489 bomi8489 commented Nov 11, 2023

📑 이슈 번호

Closes #69

🚧 구현 내용

프로필 수정 페이지를 구현했습니다.
editProfileTest

🚨 특이 사항

User interface를 수정했습니다. (어짜피 다시 수정해야하긴합니다)

export interface User {
  id: string
  name: string
  introduce: string
  profile: string
  category: string
  newsLetter: boolean
  mySpaces: {
    name?: string
    id?: string
  }[]
  favoriteSpaces: {
    name?: string
    id?: string
  }[]
}

그에 따른 LinkItemProps interface를 수정했습니다.

export interface LinkItemProps {
  title: string
  url: string
  tag: string
  readUsers?: Pick<User, 'id' | 'profile'>[] // 기존: User[]
  likes: number
  read?: boolean
  summary?: boolean
  edit?: boolean
  type?: 'list' | 'card'
}

@bomi8489 bomi8489 added the ✨ Feature 기능 개발 label Nov 11, 2023
@bomi8489 bomi8489 added this to the 2차 스프린트 milestone Nov 11, 2023
@bomi8489 bomi8489 self-assigned this Nov 11, 2023
Copy link
Member

@eeseung eeseung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

얼른 타입 정의를 해야겠네요..!! LGTM 입니다! 👏

@@ -23,7 +23,7 @@ export interface LinkItemProps {
title: string
url: string
tag: string
readUsers?: User[]
readUsers?: Pick<User, 'id' | 'profile'>[]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

타입스크립트 잘알이시네요 👍

Copy link
Contributor

@dudwns dudwns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다!

@bomi8489 bomi8489 merged commit d0b5029 into develop Nov 13, 2023
1 check passed
@bomi8489 bomi8489 deleted the feature/#69/edit-profile-page branch November 13, 2023 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Feature 기능 개발
Projects
None yet
Development

Successfully merging this pull request may close these issues.

프로필 수정 페이지 구현
3 participants