Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

링크 생성, 수정 폼 validation 조건 추가 #251

Merged
merged 4 commits into from
Dec 3, 2023
Merged

링크 생성, 수정 폼 validation 조건 추가 #251

merged 4 commits into from
Dec 3, 2023

Conversation

dudwns
Copy link
Contributor

@dudwns dudwns commented Dec 3, 2023 •
edited
Loading

📑 이슈 번호

#248

🚧 구현 내용

validation 변경

  • url에 백엔드 측과 동일한 프로토콜 형식만 가능하도록 validation을 추가하였습니다. (https, http, file만 가능)
  • title에 빈 값을 넣었을 때 validation을 추가하였습니다.

Dec-03-2023 15-26-27


좋아요 버튼 문제 수정

  • 좋아요를 클릭하고 다른 페이지를 이동했다가 다시 돌아오면 반영이 안 되어있던 문제를 수정하였습니다.

Dec-03-2023 15-41-54

🚨 특이 사항

@dudwns dudwns added the ✨ Feature 기능 개발 label Dec 3, 2023
@dudwns dudwns added this to the 4차 스프린트 milestone Dec 3, 2023
@dudwns dudwns self-assigned this Dec 3, 2023
@dudwns dudwns linked an issue Dec 3, 2023 that may be closed by this pull request
링크 생성, 수정 폼 validation 조건 추가 #248
Closed
1 task
eeseung
eeseung approved these changes Dec 3, 2023
View reviewed changes
Copy link
Member

@eeseung eeseung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 입니다!! 👏

@dudwns dudwns merged commit e73d457 into develop Dec 3, 2023
1 check passed
@dudwns dudwns deleted the feature/#248/add-link-validation branch December 3, 2023 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eeseung eeseung eeseung approved these changes

Assignees

@dudwns dudwns

Labels
✨ Feature 기능 개발
Projects
None yet
Milestone
4차 스프린트
Development

Successfully merging this pull request may close these issues.

링크 생성, 수정 폼 validation 조건 추가
2 participants
@dudwns @eeseung