Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropdown, Comment 컴포넌트 UI 수정 #250

Merged
merged 4 commits into from
Dec 3, 2023

Conversation

eeseung
Copy link
Member

@eeseung eeseung commented Dec 3, 2023

📑 이슈 번호

🚧 구현 내용

Dropdown 컴포넌트 UI를 수정했습니다.

  • Dropdown 컴포넌트에서 제거 항목을 위한 danger prop을 임시 제거했습니다.

    LinkHub-FE_style-dropdown_01
  • 태그가 많을 경우를 고려해 Dropdown 컴포넌트 max-height, overflow 를 추가했습니다.

    LinkHub-FE_style-dropdown_02.mov

Comment 컴포넌트 답글이 없는 경우 표시를 제거했습니다.

LinkHub-FE_style-dropdown_03

🚨 특이 사항

Input 컴포넌트 수정

  • 검색창에서 드롭다운과 있으면 일정 크기 이하로 줄어들지 않아서 input size 속성을 15로 수정했습니다. (default: 20)

    LinkHub-FE_style-dropdown_04

@eeseung eeseung linked an issue Dec 3, 2023 that may be closed by this pull request
1 task
@eeseung eeseung self-assigned this Dec 3, 2023
@eeseung eeseung added the 🎨 Style 마크업 & 스타일링 label Dec 3, 2023
@eeseung eeseung added this to the 4차 스프린트 milestone Dec 3, 2023
@eeseung eeseung changed the title Dropdown 컴포넌트 UI 수정 Dropdown & Comment 컴포넌트 UI 수정 Dec 3, 2023
@eeseung eeseung changed the title Dropdown & Comment 컴포넌트 UI 수정 Dropdown, Comment 컴포넌트 UI 수정 Dec 3, 2023
Copy link
Contributor

@bomi8489 bomi8489 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻👍🏻👍🏻

Copy link
Contributor

@dudwns dudwns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 입니다! 👍

@eeseung eeseung merged commit 6dc74b4 into develop Dec 3, 2023
1 check passed
@eeseung eeseung deleted the feature/#245/style-dropdown branch December 3, 2023 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 Style 마크업 & 스타일링
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dropdown, Comment 컴포넌트 UI 수정
3 participants