[FIX] popularRate 관련 오류 수정 #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddongseop
approved these changes
Mar 27, 2024
| @@ -64,18 +64,22 @@ public void addFavorite(Favorite favorite) { | |||
| favorites.add(favorite); | |||
| } | |||
|
|
|||
| @Column(nullable = false) | |||
| private int popularRate = 0; | |||
There was a problem hiding this comment.
[P2] int 필드는 null일 수가 없습니다. 따라서 nullable=false를 작성할 필요가 없습니다!
그리고 기본값이 자동으로 0으로 설정됩니다.
하지만 가독성을 위해 0을 적는것도 괜찮은 선택지일 수 있을듯 합니다~
There was a problem hiding this comment.
아하 까머것다 캬캬
감사합니당 ~~~!!
| @Builder | ||
| public Book(String uuid, String favoriteName, String favoriteImage, String title, String description, String backgroundColor, Member member) { | ||
| public Book(String uuid, String favoriteName, String favoriteImage, String title, String description, String backgroundColor, Member member, int popularRate) { |
There was a problem hiding this comment.
[P3] 지금 현재 생성할 때 popularRate를 넣어주고 있지 않고,
이후에 스케줄링으로 popularRate를 설정해줄 때도 생성할 시점에 값을 넣어주지는 않기 때문에 생성자에 추가한 부분은 없어도 될 것 같습니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 관련 이슈
closed #80
✨ 어떤 이유로 변경된 내용인지
🙏 검토 혹은 리뷰어에게 남기고 싶은 말