Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge: (#281) 일정 dto 리팩토링 #304

Merged
merged 11 commits into from
Jan 16, 2023

Conversation

khcho0125
Copy link
Member

@khcho0125 khcho0125 commented Jan 12, 2023

작업 내용 설명

  • 일정 dto 리팩토링

주요 변경 사항

  • WebRequest → Request 클래스 명 변경
  • Request → Data 클래스 명 변경
  • Request toData 메서드 추가

체크리스트

  • 어플리케이션 구동(혹은 테스트)시 오류는 없나요?
  • 생성된 코드에 Javadoc 주석을 추가 하였나요?
  • 생성된 코드에 대한 테스트 코드가 작성 되었나요?

관련 이슈

@khcho0125 khcho0125 added the refactor 코드 리팩토링 할 경우 label Jan 12, 2023
@khcho0125 khcho0125 self-assigned this Jan 12, 2023
@codecov
Copy link

codecov bot commented Jan 12, 2023

Codecov Report

Merging #304 (eaf17ee) into develop (15f7bed) will decrease coverage by 0.07%.
The diff coverage is 18.91%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop     #304      +/-   ##
=============================================
- Coverage      38.59%   38.51%   -0.08%     
+ Complexity       375      373       -2     
=============================================
  Files            237      237              
  Lines           2920     2918       -2     
  Branches          99       99              
=============================================
- Hits            1127     1124       -3     
- Misses          1787     1788       +1     
  Partials           6        6              
Impacted Files Coverage Δ
...le/dto/response/QueryEntireSpotScheduleResponse.kt 100.00% <ø> (ø)
...to/response/QueryIndividualSpotScheduleResponse.kt 100.00% <ø> (ø)
...n/schedule/usecase/AddIndividualScheduleUseCase.kt 94.73% <ø> (ø)
...schedule/usecase/QueryEntireSpotScheduleUseCase.kt 100.00% <ø> (ø)
...dule/usecase/QueryIndividualSpotScheduleUseCase.kt 100.00% <ø> (ø)
...omit/simtong/domain/schedule/WebScheduleAdapter.kt 0.00% <0.00%> (ø)
...omain/schedule/dto/AddIndividualScheduleRequest.kt 0.00% <0.00%> (ø)
...tong/domain/schedule/dto/AddSpotScheduleRequest.kt 0.00% <0.00%> (ø)
...in/schedule/dto/ChangeIndividualScheduleRequest.kt 0.00% <0.00%> (ø)
...g/domain/schedule/dto/ChangeSpotScheduleRequest.kt 0.00% <0.00%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15f7bed...eaf17ee. Read the comment docs.

@sonarcloud
Copy link

sonarcloud bot commented Jan 15, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 11 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@khcho0125 khcho0125 merged commit 3ccaecc into develop Jan 16, 2023
@khcho0125 khcho0125 deleted the refactor/281-schedule-dto-package branch January 16, 2023 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor 코드 리팩토링 할 경우
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants