Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge: (#286) File, Menu Aggregate, Notification 도메인 리팩토링 #296

Merged
merged 3 commits into from
Jan 9, 2023

Conversation

softpeanut
Copy link
Member

@softpeanut softpeanut commented Jan 9, 2023

작업 내용 설명

  • 줄바꿈 삭제

주요 변경 사항

체크리스트

  • 어플리케이션 구동(혹은 테스트)시 오류는 없나요?
  • 생성된 코드에 Javadoc 주석을 추가 하였나요?
  • 생성된 코드에 대한 테스트 코드가 작성 되었나요?

관련 이슈

@softpeanut softpeanut added the refactor 코드 리팩토링 할 경우 label Jan 9, 2023
@softpeanut softpeanut self-assigned this Jan 9, 2023
khcho0125
khcho0125 previously approved these changes Jan 9, 2023
Copy link
Member

@khcho0125 khcho0125 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@softpeanut softpeanut changed the title merge: (#286) File, Menu Aggregate 도메인 리팩토링 merge: (#286) File, Menu Aggregate, Notification 도메인 리팩토링 Jan 9, 2023
@codecov
Copy link

codecov bot commented Jan 9, 2023

Codecov Report

Merging #296 (ad1379e) into develop (6cd4164) will increase coverage by 0.01%.
The diff coverage is 50.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop     #296      +/-   ##
=============================================
+ Coverage      37.68%   37.70%   +0.01%     
  Complexity       353      353              
=============================================
  Files            236      236              
  Lines           2850     2854       +4     
  Branches         101      101              
=============================================
+ Hits            1074     1076       +2     
- Misses          1773     1775       +2     
  Partials           3        3              
Impacted Files Coverage Δ
...file/usecase/RegisterEmployeeCertificateUseCase.kt 100.00% <ø> (ø)
.../simtong/domain/file/usecase/UploadImageUseCase.kt 100.00% <ø> (ø)
...ong/domain/menu/usecase/QueryMenuByMonthUseCase.kt 100.00% <ø> (ø)
...tong/domain/menu/usecase/QueryPublicMenuUseCase.kt 100.00% <ø> (ø)
.../simtong/domain/notification/model/Notification.kt 0.00% <0.00%> (ø)
.../domain/notification/model/NotificationReceiver.kt 0.00% <0.00%> (ø)
...t/simtong/domain/file/model/EmployeeCertificate.kt 100.00% <100.00%> (ø)
...omit/simtong/domain/holiday/model/HolidayPeriod.kt 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6cd4164...ad1379e. Read the comment docs.

@sonarcloud
Copy link

sonarcloud bot commented Jan 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@khcho0125 khcho0125 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이건 또 왜 빠져있는 거야;;

@softpeanut softpeanut merged commit 56a3336 into develop Jan 9, 2023
@softpeanut softpeanut deleted the refactor/286-domain-driven-code-menu branch January 9, 2023 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor 코드 리팩토링 할 경우
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants