Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

merge: (#281) 유저 dto 관련 리팩토링 #303

Merged
merged 18 commits into from
Jan 14, 2023
Merged

merge: (#281) 유저 dto 관련 리팩토링 #303

merged 18 commits into from
Jan 14, 2023

Conversation

khcho0125
Copy link
Member

@khcho0125 khcho0125 commented Jan 12, 2023 •
edited
Loading

작업 내용 설명

  • Dto 패키지 이동
  • 클래스 명 변경

주요 변경 사항

  • Request에 toData 함수 추가

추가 사항

  • Application 계층 user 패키지가 같이 변경되어 Admin과 Common에 영향이 있습니다.
  • 추후에 Admin과 Common 진행할 시 변경하도록 할게요

체크리스트

  • 어플리케이션 구동(혹은 테스트)시 오류는 없나요?
  • 생성된 코드에 Javadoc 주석을 추가 하였나요?
  • 생성된 코드에 대한 테스트 코드가 작성 되었나요?

관련 이슈

@khcho0125 khcho0125 self-assigned this Jan 12, 2023
@khcho0125 khcho0125 added the refactor 코드 리팩토링 할 경우 label Jan 12, 2023
@khcho0125 khcho0125 changed the base branch from main to develop January 12, 2023 15:10
@codecov
Copy link

codecov bot commented Jan 12, 2023 •
edited
Loading

Codecov Report

Merging #303 (83c0d8a) into develop (0bd21fc) will decrease coverage by 0.06%.
The diff coverage is 25.77%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop     #303      +/-   ##
=============================================
- Coverage      38.87%   38.81%   -0.07%     
- Complexity       370      372       +2     
=============================================
  Files            239      237       -2     
  Lines           2899     2909      +10     
  Branches          99       99              
=============================================
+ Hits            1127     1129       +2     
- Misses          1766     1774       +8     
  Partials           6        6
Impacted Files Coverage Δ
...domain/user/dto/response/QueryAdminInfoResponse.kt 100.00% <ø> (ø)
.../domain/user/dto/response/QueryUserInfoResponse.kt 100.00% <ø> (ø)
.../simtong/domain/user/usecase/AdminSignInUseCase.kt 100.00% <ø> (ø)
.../simtong/domain/user/usecase/ChangeEmailUseCase.kt 100.00% <ø> (ø)
...mtong/domain/user/usecase/ChangeNicknameUseCase.kt 100.00% <ø> (ø)
...mtong/domain/user/usecase/ChangePasswordUseCase.kt 100.00% <ø> (ø)
...g/domain/user/usecase/ChangeProfileImageUseCase.kt 100.00% <ø> (ø)
.../domain/user/usecase/CheckMatchedAccountUseCase.kt 100.00% <ø> (ø)
...g/domain/user/usecase/FindEmployeeNumberUseCase.kt 100.00% <ø> (ø)
...mtong/domain/user/usecase/QueryAdminInfoUseCase.kt 100.00% <ø> (ø)
... and 29 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0bd21fc...83c0d8a. Read the comment docs.

@khcho0125 khcho0125 mentioned this pull request Jan 12, 2023
Merged
4 tasks
@sonarcloud
Copy link

sonarcloud bot commented Jan 13, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

softpeanut
softpeanut approved these changes Jan 14, 2023
View reviewed changes
Copy link
Member

@softpeanut softpeanut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

conflict 해결은 잘 하셨으리라 믿겠습니다..!

@khcho0125 khcho0125 merged commit b71322c into develop Jan 14, 2023
@khcho0125 khcho0125 deleted the refactor/281-user-dto-package branch January 14, 2023 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@softpeanut softpeanut softpeanut approved these changes

Assignees

@khcho0125 khcho0125

Labels
refactor 코드 리팩토링 할 경우
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Presentation 계층 Domain 의존
2 participants
@khcho0125 @softpeanut