Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Move shared project config out of routes directory #144

Merged
merged 6 commits into from
Jan 20, 2024

Conversation

lachlancollins
Copy link
Member

Before, the routes would import constants from each other, such as import { v8branch } from '~/routes/table.v8'

This PR refactors any shared project config out of routes and into a projects directory.

This will make migrating to a different router easier, since the shared code is outside the routes directory, and can therefore be used without changes.

Copy link

vercel bot commented Jan 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tanstack-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 20, 2024 8:12am

@lachlancollins lachlancollins changed the title refactor: Move shared project config out of routes refactor: Move shared project config out of routes directory Jan 20, 2024
@tannerlinsley
Copy link
Collaborator

Approved, but needs rebase

@lachlancollins
Copy link
Member Author

Approved, but needs rebase

I've resolved the conflicts 👍

@tannerlinsley tannerlinsley merged commit 5396920 into main Jan 20, 2024
4 checks passed
@lachlancollins lachlancollins deleted the refactor-config branch January 20, 2024 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants