Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint-plugin-query): get scope from sourceCode #7760

Merged
merged 1 commit into from
Jul 18, 2024

Conversation

TkDodo
Copy link
Collaborator

@TkDodo TkDodo commented Jul 18, 2024

in eslint v9, context.getScope() doesn't exist anymore. see: https://eslint.org/blog/2023/09/preparing-custom-rules-eslint-v9/#context.getscope()

@TkDodo TkDodo marked this pull request as ready for review July 18, 2024 11:03
Copy link

nx-cloud bot commented Jul 18, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit a9ff39f. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

Copy link

pkg-pr-new bot commented Jul 18, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

commit: a9ff39f

@tanstack/angular-query-devtools-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-devtools-experimental@7760

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@7760

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@7760

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@7760

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@7760

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@7760

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@7760

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@7760

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@7760

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@7760

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@7760

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@7760

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@7760

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@7760

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@7760

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@7760

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@7760

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@7760

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@7760

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@7760

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@7760


templates

Copy link

codecov bot commented Jul 18, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 84.00%. Comparing base (ae8738a) to head (a9ff39f).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #7760       +/-   ##
===========================================
+ Coverage   44.63%   84.00%   +39.36%     
===========================================
  Files         185       11      -174     
  Lines        7075      350     -6725     
  Branches     1565      129     -1436     
===========================================
- Hits         3158      294     -2864     
+ Misses       3554       42     -3512     
+ Partials      363       14      -349     
Components Coverage Δ
@tanstack/angular-query-devtools-experimental ∅ <ø> (∅)
@tanstack/angular-query-experimental ∅ <ø> (∅)
@tanstack/eslint-plugin-query 84.00% <80.00%> (-0.15%) ⬇️
@tanstack/query-async-storage-persister ∅ <ø> (∅)
@tanstack/query-broadcast-client-experimental ∅ <ø> (∅)
@tanstack/query-codemods ∅ <ø> (∅)
@tanstack/query-core ∅ <ø> (∅)
@tanstack/query-devtools ∅ <ø> (∅)
@tanstack/query-persist-client-core ∅ <ø> (∅)
@tanstack/query-sync-storage-persister ∅ <ø> (∅)
@tanstack/react-query ∅ <ø> (∅)
@tanstack/react-query-devtools ∅ <ø> (∅)
@tanstack/react-query-next-experimental ∅ <ø> (∅)
@tanstack/react-query-persist-client ∅ <ø> (∅)
@tanstack/solid-query ∅ <ø> (∅)
@tanstack/solid-query-devtools ∅ <ø> (∅)
@tanstack/solid-query-persist-client ∅ <ø> (∅)
@tanstack/svelte-query ∅ <ø> (∅)
@tanstack/svelte-query-devtools ∅ <ø> (∅)
@tanstack/svelte-query-persist-client ∅ <ø> (∅)
@tanstack/vue-query ∅ <ø> (∅)
@tanstack/vue-query-devtools ∅ <ø> (∅)

@TkDodo TkDodo merged commit e61edd2 into main Jul 18, 2024
8 checks passed
@TkDodo TkDodo deleted the feature/fix-ast-utils branch July 18, 2024 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant