Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(solid-query): Fix race condition issues with createQuery #7748

Merged
merged 2 commits into from
Jul 17, 2024
Merged

fix(solid-query): Fix race condition issues with createQuery #7748

merged 2 commits into from
Jul 17, 2024

Conversation

ardeora
Copy link
Contributor

@ardeora ardeora commented Jul 17, 2024

Fixes #7711

Fixes a race condition with the createQuery primitive that would keep an observer subscribed even when the component that spawned the query was unmounted.

I have also added broken tests that have been fixed now

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Jul 17, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 84ba28a. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Jul 17, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

commit: 84ba28a

@tanstack/angular-query-devtools-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-devtools-experimental@7748

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@7748

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@7748

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@7748

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@7748

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@7748

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@7748

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@7748

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@7748

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@7748

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@7748

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@7748

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@7748

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@7748

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@7748

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@7748

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@7748

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@7748

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@7748

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@7748

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@7748

templates

@ardeora ardeora merged commit ffb11b3 into TanStack:main Jul 17, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
package: solid-query
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Query remains active even without any listeners
1 participant
@ardeora