Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: logo display change #5380

Merged
merged 2 commits into from
Jul 23, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/calm-grapes-know.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@talend/bootstrap-theme': patch
---

fix: remove animation on all button for all change
5 changes: 5 additions & 0 deletions .changeset/modern-waves-fail.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@talend/design-tokens': patch
---

fix: revert logo change
5 changes: 5 additions & 0 deletions .changeset/silly-hats-work.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@talend/design-system': patch
---

fix: useLayoutEffect to set the data-theme
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { PropsWithChildren, useContext, useEffect, useState } from 'react';
import { PropsWithChildren, useContext, useLayoutEffect, useState } from 'react';

import 'modern-css-reset/dist/reset.min.css';
import 'typeface-inconsolata/index.css';
Expand All @@ -25,15 +25,15 @@ export const ThemeProvider = ({
// Handle nested Providers: parent Provider doesn't have context, child does
const context = useContext(ThemeContext);

useEffect(() => {
useLayoutEffect(() => {
document.body.dataset.theme = selectedTheme;
}, [selectedTheme]);

useEffect(() => {
useLayoutEffect(() => {
setSelectedTheme(theme);
}, [theme]);

useEffect(() => {
useLayoutEffect(() => {
if (tokensOverride) {
Object.keys(tokensOverride).forEach(key => {
document.body.style.setProperty(key, tokensOverride[key].toString());
Expand Down
2 changes: 1 addition & 1 deletion packages/design-tokens/src/_tokens.scss

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion packages/design-tokens/src/light/_index.scss

Large diffs are not rendered by default.

Loading
Loading