chore(TDOPS-5724): remove react bootstrap #5045

Gbacc · 2023-12-07T13:03:22Z

What is the problem this PR is trying to solve?
remove react bootstrap from

forms
containers
components

What is the chosen solution to this problem?

Please check if the PR fulfills these requirements

The PR have used yarn changeset to a request a release from the CI if wanted.
The PR commit message follows our guidelines
Tests for the changes have been added (for bug fixes / features) And non reg done before need review
Docs have been added / updated (for bug fixes / features)
Related design / discussions / pages (not in jira), if any, are all linked or available in the PR

[ ] This PR introduces a breaking change

github-actions · 2023-12-07T13:11:24Z

5045

Demo is available here

github-actions · 2023-12-07T13:17:58Z

Size Change: -684 B (0%)

Total Size: 16.6 MB

Filename	Size	Change
`./packages/components/dist/TalendReactComponents.js`	4.72 MB	-1.48 kB (0%)
`./packages/components/dist/TalendReactComponents.min.js`	1.29 MB	-155 B (0%)
`./packages/containers/dist/TalendReactContainers.css`	3.67 kB	+657 B (+22%)	🚨
`./packages/containers/dist/TalendReactContainers.js.dependencies.json`	1.4 kB	-147 B (-10%)	👏
`./packages/containers/dist/TalendReactContainers.min.css`	2.34 kB	+600 B (+35%)	🚨
`./packages/containers/dist/TalendReactContainers.min.js.dependencies.json`	1.45 kB	-151 B (-9%)	✅

ℹ️ View Unchanged

Filename	Size	Change
`./packages/assets-api/dist/TalendAssetsApi.js`	7.21 kB	0 B
`./packages/assets-api/dist/TalendAssetsApi.js.dependencies.json`	2 B	0 B
`./packages/assets-api/dist/TalendAssetsApi.min.js`	3.34 kB	0 B
`./packages/assets-api/dist/TalendAssetsApi.min.js.dependencies.json`	2 B	0 B
`./packages/cmf-cqrs/dist/TalendReactCmfCqrs.js`	210 kB	0 B
`./packages/cmf-cqrs/dist/TalendReactCmfCqrs.js.dependencies.json`	672 B	0 B
`./packages/cmf-cqrs/dist/TalendReactCmfCqrs.min.js`	39.7 kB	0 B
`./packages/cmf-cqrs/dist/TalendReactCmfCqrs.min.js.dependencies.json`	695 B	0 B
`./packages/cmf-router/dist/TalendReactCmfRouter.js`	164 kB	0 B
`./packages/cmf-router/dist/TalendReactCmfRouter.js.dependencies.json`	1.25 kB	0 B
`./packages/cmf-router/dist/TalendReactCmfRouter.min.js`	13 kB	0 B
`./packages/cmf-router/dist/TalendReactCmfRouter.min.js.dependencies.json`	1.29 kB	0 B
`./packages/cmf/dist/TalendReactCmf.js`	745 kB	0 B
`./packages/cmf/dist/TalendReactCmf.js.dependencies.json`	1.31 kB	0 B
`./packages/cmf/dist/TalendReactCmf.min.js`	140 kB	0 B
`./packages/cmf/dist/TalendReactCmf.min.js.dependencies.json`	1.35 kB	0 B
`./packages/components/dist/TalendReactComponents.css`	403 kB	0 B
`./packages/components/dist/TalendReactComponents.js.dependencies.json`	3.21 kB	0 B
`./packages/components/dist/TalendReactComponents.min.css`	210 kB	0 B
`./packages/components/dist/TalendReactComponents.min.js.dependencies.json`	3.29 kB	0 B
`./packages/containers/dist/TalendReactContainers.js`	642 kB	-82 B (0%)
`./packages/containers/dist/TalendReactContainers.min.js`	122 kB	+73 B (0%)
`./packages/dataviz/dist/TalendReactDataviz.css`	28.9 kB	0 B
`./packages/dataviz/dist/TalendReactDataviz.js`	373 kB	0 B
`./packages/dataviz/dist/TalendReactDataviz.js.dependencies.json`	1.15 kB	0 B
`./packages/dataviz/dist/TalendReactDataviz.min.css`	12 kB	0 B
`./packages/dataviz/dist/TalendReactDataviz.min.js`	63.6 kB	0 B
`./packages/dataviz/dist/TalendReactDataviz.min.js.dependencies.json`	1.19 kB	0 B
`./packages/design-system/dist/TalendDesignSystem.css`	289 kB	0 B
`./packages/design-system/dist/TalendDesignSystem.js`	1.32 MB	0 B
`./packages/design-system/dist/TalendDesignSystem.js.dependencies.json`	1.57 kB	0 B
`./packages/design-system/dist/TalendDesignSystem.min.css`	176 kB	0 B
`./packages/design-system/dist/TalendDesignSystem.min.js`	261 kB	0 B
`./packages/design-system/dist/TalendDesignSystem.min.js.dependencies.json`	1.61 kB	0 B
`./packages/design-tokens/dist/TalendDesignTokens.css`	44.6 kB	0 B
`./packages/design-tokens/dist/TalendDesignTokens.js`	39.6 kB	0 B
`./packages/design-tokens/dist/TalendDesignTokens.js.dependencies.json`	2 B	0 B
`./packages/design-tokens/dist/TalendDesignTokens.min.css`	41.5 kB	0 B
`./packages/design-tokens/dist/TalendDesignTokens.min.js`	33.3 kB	0 B
`./packages/design-tokens/dist/TalendDesignTokens.min.js.dependencies.json`	2 B	0 B
`./packages/faceted-search/dist/TalendReactFacetedSearch.css`	37.5 kB	0 B
`./packages/faceted-search/dist/TalendReactFacetedSearch.js`	558 kB	0 B
`./packages/faceted-search/dist/TalendReactFacetedSearch.js.dependencies.json`	1.36 kB	0 B
`./packages/faceted-search/dist/TalendReactFacetedSearch.min.css`	16.8 kB	0 B
`./packages/faceted-search/dist/TalendReactFacetedSearch.min.js`	119 kB	0 B
`./packages/faceted-search/dist/TalendReactFacetedSearch.min.js.dependencies.json`	1.4 kB	0 B
`./packages/flow-designer/dist/TalendReactFlowDesigner.min.js`	51.5 kB	0 B
`./packages/flow-designer/dist/TalendReactFlowDesigner.min.js.dependencies.json`	1.25 kB	0 B
`./packages/forms/dist/TalendReactForms.css`	37.6 kB	0 B
`./packages/forms/dist/TalendReactForms.js`	879 kB	0 B
`./packages/forms/dist/TalendReactForms.js.dependencies.json`	1.35 kB	0 B
`./packages/forms/dist/TalendReactForms.min.css`	12.8 kB	0 B
`./packages/forms/dist/TalendReactForms.min.js`	222 kB	0 B
`./packages/forms/dist/TalendReactForms.min.js.dependencies.json`	1.39 kB	0 B
`./packages/http/dist/TalendHttp.js`	24.9 kB	0 B
`./packages/http/dist/TalendHttp.js.dependencies.json`	2 B	0 B
`./packages/http/dist/TalendHttp.min.js`	5.33 kB	0 B
`./packages/http/dist/TalendHttp.min.js.dependencies.json`	2 B	0 B
`./packages/icons/dist/bundle.js`	1.26 kB	0 B
`./packages/icons/dist/info.js`	26.1 kB	0 B
`./packages/icons/dist/react.esm.js`	585 kB	0 B
`./packages/icons/dist/react.js`	623 kB	0 B
`./packages/icons/dist/talend-icons-webfont.css`	17.4 kB	0 B
`./packages/icons/dist/talendicons.css`	334 B	0 B
`./packages/icons/dist/TalendIcons.js`	752 kB	0 B
`./packages/icons/dist/TalendIcons.js.dependencies.json`	128 B	0 B
`./packages/icons/dist/TalendIcons.min.js`	606 kB	0 B
`./packages/icons/dist/TalendIcons.min.js.dependencies.json`	131 B	0 B
`./packages/icons/dist/typeUtils.js`	14.4 kB	0 B
`./packages/jsfc/dist/index.js`	86.8 kB	0 B
`./packages/jsfc/dist/index.js.dependencies.json`	2 B	0 B
`./packages/router-bridge/dist/TalendRouterBridge.js`	134 kB	0 B
`./packages/router-bridge/dist/TalendRouterBridge.js.dependencies.json`	1.05 kB	0 B
`./packages/router-bridge/dist/TalendRouterBridge.min.js`	21 kB	0 B
`./packages/router-bridge/dist/TalendRouterBridge.min.js.dependencies.json`	1.07 kB	0 B
`./packages/sagas/dist/TalendReactSagas.js`	10.9 kB	0 B
`./packages/sagas/dist/TalendReactSagas.js.dependencies.json`	348 B	0 B
`./packages/sagas/dist/TalendReactSagas.min.js`	1.41 kB	0 B
`./packages/sagas/dist/TalendReactSagas.min.js.dependencies.json`	360 B	0 B
`./packages/stepper/dist/TalendReactStepper.css`	2.4 kB	0 B
`./packages/stepper/dist/TalendReactStepper.js`	97.4 kB	0 B
`./packages/stepper/dist/TalendReactStepper.js.dependencies.json`	1.27 kB	0 B
`./packages/stepper/dist/TalendReactStepper.min.css`	1.19 kB	0 B
`./packages/stepper/dist/TalendReactStepper.min.js`	9.64 kB	0 B
`./packages/stepper/dist/TalendReactStepper.min.js.dependencies.json`	1.31 kB	0 B
`./packages/storybook-docs/dist/globalStyles.js`	0 B	0 B	🆕
`./packages/storybook-docs/dist/globalStyles.min.css`	398 B	0 B
`./packages/storybook-docs/dist/managerStyles.js`	0 B	0 B	🆕
`./packages/storybook-docs/dist/managerStyles.min.css`	1.53 kB	0 B
`./packages/theme/dist/bootstrap.css`	172 kB	0 B
`./packages/theme/dist/bootstrap.js`	2.51 kB	0 B
`./packages/theme/dist/bootstrap.js.dependencies.json`	3 B	0 B

_{compressed-size-action}

github-actions · 2023-12-07T14:36:57Z

Title	Statements	Branches	Functions
assets-api	28.4% (25/88)	30.76% (16/52)	21.42% (3/14)
cmf	89.2% (1272/1426)	80.36% (618/769)	88.91% (361/406)
cmf-cqrs	87.43% (160/183)	70.23% (59/84)	84.21% (48/57)
cmf-router	69.23% (135/195)	55.71% (78/140)	56.81% (25/44)
components	90.7% (5589/6162)	81.66% (3229/3954)	88.29% (1410/1597)
containers	83.71% (1388/1658)	74.81% (692/925)	75.17% (327/435)
dataviz	85.6% (321/375)	66.66% (160/240)	75.64% (118/156)
design-system	66.54% (899/1351)	48.56% (440/906)	53.18% (192/361)
faceted-search	84.8% (703/829)	77.8% (284/365)	81.33% (244/300)
flow-designer	70.07% (651/929)	66.72% (355/532)	70.92% (200/282)
forms	85.62% (1674/1955)	75.2% (913/1214)	84.4% (471/558)
http	100% (85/85)	98.07% (51/52)	100% (34/34)
sagas	92.3% (24/26)	66.66% (4/6)	50% (2/4)
stepper	81.52% (150/184)	59.34% (54/91)	80.85% (38/47)
utils	100% (70/70)	90.9% (10/11)	100% (22/22)

.changeset/hot-dancers-search.md

Co-authored-by: Mathieu Huchet <[email protected]>

mhuchet · 2023-12-11T09:41:33Z

packages/components/src/PieChart/PieChartButton.component.js

@@ -31,7 +33,7 @@ export function decorateWithOverlay(
 				trigger="click"
 				rootClose
 				placement={overlayPlacement}
-				overlay={<Popover id={overlayId}>{overlayComponent}</Popover>}
+				overlay={<div id={overlayId}>{overlayComponent}</div>}


There is a Popover component in Coral if we want to use it here.

Yes that's true , but i think we don't really need a popover here as overlaytrigger is already some sort of popover so it's like putting popover into your popover 😂

mhuchet · 2023-12-11T13:06:48Z

packages/components/src/Typeahead/Typeahead.component.renderers.js

 					{...rest}
+					hideLabel


We never want to display a label here?

Good question
From what i've tested it's always integrated as a quick search input without label so if there are some case we need one then we can put a condition here

Geoffroy Baccarini added 3 commits December 7, 2023 14:02

remove from forms and sandbox

3596846

remove from containers

95ea275

remove from components

0649d2d

Gbacc temporarily deployed to pull_request_unsafe December 7, 2023 13:03 — with GitHub Actions Inactive

update tests

4cba72a

Gbacc temporarily deployed to pull_request_unsafe December 7, 2023 13:31 — with GitHub Actions Inactive

update tests

62ddac8

Gbacc temporarily deployed to pull_request_unsafe December 7, 2023 13:59 — with GitHub Actions Inactive

Gbacc had a problem deploying to pull_request_unsafe December 7, 2023 13:59 — with GitHub Actions Error

update tests

bb6d691

Gbacc temporarily deployed to pull_request_unsafe December 7, 2023 14:12 — with GitHub Actions Inactive

Gbacc had a problem deploying to pull_request_unsafe December 7, 2023 14:13 — with GitHub Actions Error

Gbacc temporarily deployed to pull_request_unsafe December 7, 2023 14:13 — with GitHub Actions Inactive

update tests

7b09e6c

Gbacc temporarily deployed to pull_request_unsafe December 7, 2023 14:25 — with GitHub Actions Inactive

changeset and last minute fixes

837c6ff

Gbacc temporarily deployed to pull_request_unsafe December 7, 2023 15:56 — with GitHub Actions Inactive

mhuchet reviewed Dec 11, 2023

View reviewed changes

.changeset/hot-dancers-search.md Outdated Show resolved Hide resolved

Update .changeset/hot-dancers-search.md

46f16a9

Co-authored-by: Mathieu Huchet <[email protected]>

mhuchet reviewed Dec 11, 2023

View reviewed changes

Merge branch 'master' into gbacc/chore/TDOPS-5724-remove-react-bootstrap

c9c7394

Gbacc temporarily deployed to pull_request_unsafe December 11, 2023 13:19 — with GitHub Actions Inactive

mhuchet approved these changes Dec 11, 2023

View reviewed changes

romainseb approved these changes Dec 13, 2023

View reviewed changes

Gbacc merged commit 7de44f9 into master Dec 13, 2023
12 checks passed

Gbacc deleted the gbacc/chore/TDOPS-5724-remove-react-bootstrap branch December 13, 2023 13:14

Gbacc had a problem deploying to pull_request_unsafe December 13, 2023 13:14 — with GitHub Actions Failure

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(TDOPS-5724): remove react bootstrap #5045

chore(TDOPS-5724): remove react bootstrap #5045

Gbacc commented Dec 7, 2023 •

edited

Loading

github-actions bot commented Dec 7, 2023

github-actions bot commented Dec 7, 2023 •

edited

Loading

github-actions bot commented Dec 7, 2023 •

edited

Loading

mhuchet Dec 11, 2023

Gbacc Dec 11, 2023

mhuchet Dec 11, 2023

Gbacc Dec 11, 2023

chore(TDOPS-5724): remove react bootstrap #5045

chore(TDOPS-5724): remove react bootstrap #5045

Conversation

Gbacc commented Dec 7, 2023 • edited Loading

github-actions bot commented Dec 7, 2023

github-actions bot commented Dec 7, 2023 • edited Loading

github-actions bot commented Dec 7, 2023 • edited Loading

mhuchet Dec 11, 2023

Choose a reason for hiding this comment

Gbacc Dec 11, 2023

Choose a reason for hiding this comment

mhuchet Dec 11, 2023

Choose a reason for hiding this comment

Gbacc Dec 11, 2023

Choose a reason for hiding this comment

Gbacc commented Dec 7, 2023 •

edited

Loading

github-actions bot commented Dec 7, 2023 •

edited

Loading

github-actions bot commented Dec 7, 2023 •

edited

Loading