-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(TDOPS-4789/facetedSearch): callback support for BadgeMenu #5022
Conversation
Size Change: +1.68 kB (0%) Total Size: 13.4 MB
ℹ️ View Unchanged
|
packages/faceted-search/src/components/Badges/BadgeMenu/BadgeMenu.component.js
Outdated
Show resolved
Hide resolved
await waitFor(() => { | ||
expect(screen.getByRole('menuitem')).toBeVisible(); | ||
}); | ||
screen.logTestingPlaygroundURL(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
debugging line can be removed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed
const currentOperators = useMemo(() => operators, [operators]); | ||
const currentOperator = operator || (currentOperators && currentOperators[0]); | ||
const [isLoading, setIsLoading] = useState(true); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe better to set isLoading false by default? then no need for this line: https://github.com/Talend/ui/pull/5022/files#diff-9cd7307a01bfb12fcee969fa3d4f76874a44bf7dc27b1c37d95e3157942ee263R51
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
@@ -119,6 +127,8 @@ const BadgeMenuForm = ({ | |||
type="submit" | |||
label={t('APPLY', { defaultValue: 'Apply' })} | |||
bsStyle="info" | |||
disabled={rest.isLoading} | |||
inProgress={rest.isLoading} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO no need set inProgress
to true when loading options, just disable submit button is enough. set inProgress
to true when it's submitting.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed
@@ -39,6 +39,7 @@ const badgeFacetedPropTypes = PropTypes.shape({ | |||
isInCreation: PropTypes.bool, | |||
entitiesPerBadge: PropTypes.string, | |||
operators: PropTypes.arrayOf(PropTypes.string), | |||
isLoading: PropTypes.bool, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to add isLoading to metadata?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed
What is the problem this PR is trying to solve?
callback support for BadgeMenu
What is the chosen solution to this problem?
Please check if the PR fulfills these requirements
yarn changeset
to a request a release from the CI if wanted.[ ] This PR introduces a breaking change