feat(TDOPS-4789/facetedSearch): callback support for BadgeMenu #5022

ybaskaran · 2023-11-30T14:30:55Z

What is the problem this PR is trying to solve?
callback support for BadgeMenu

What is the chosen solution to this problem?

Please check if the PR fulfills these requirements

The PR have used yarn changeset to a request a release from the CI if wanted.
The PR commit message follows our guidelines
Tests for the changes have been added (for bug fixes / features) And non reg done before need review
Docs have been added / updated (for bug fixes / features)
Related design / discussions / pages (not in jira), if any, are all linked or available in the PR

[ ] This PR introduces a breaking change

github-actions · 2023-11-30T14:40:38Z

5022

Demo is available here

github-actions · 2023-11-30T14:42:41Z

Title	Statements	Branches	Functions
assets-api	28.4% (25/88)	30.76% (16/52)	21.42% (3/14)
cmf	89.2% (1272/1426)	80.36% (618/769)	88.91% (361/406)
cmf-cqrs	87.43% (160/183)	70.23% (59/84)	84.21% (48/57)
cmf-router	69.23% (135/195)	55.71% (78/140)	56.81% (25/44)
components	90.5% (5614/6203)	81.48% (3231/3965)	87.76% (1420/1618)
containers	83.71% (1388/1658)	74.81% (692/925)	75.17% (327/435)
dataviz	85.6% (321/375)	66.66% (160/240)	75.64% (118/156)
design-system	66.54% (899/1351)	48.56% (440/906)	53.18% (192/361)
faceted-search	85.18% (707/830)	77.83% (281/361)	82% (246/300)
flow-designer	70.07% (651/929)	66.72% (355/532)	70.92% (200/282)
forms	85.62% (1674/1955)	75.2% (913/1214)	84.4% (471/558)
http	100% (85/85)	98.07% (51/52)	100% (34/34)
sagas	92.3% (24/26)	66.66% (4/6)	50% (2/4)
stepper	81.52% (150/184)	59.34% (54/91)	80.85% (38/47)
utils	100% (62/62)	90.9% (10/11)	100% (16/16)

github-actions · 2023-11-30T14:46:20Z

Size Change: +1.68 kB (0%)

Total Size: 13.4 MB

Filename	Size	Change
`./packages/faceted-search/dist/TalendReactFacetedSearch.js`	450 kB	+1.15 kB (0%)
`./packages/faceted-search/dist/TalendReactFacetedSearch.min.js`	101 kB	+358 B (0%)

ℹ️ View Unchanged

Filename	Size	Change
`./packages/assets-api/dist/TalendAssetsApi.js`	7.21 kB	0 B
`./packages/assets-api/dist/TalendAssetsApi.js.dependencies.json`	2 B	0 B
`./packages/assets-api/dist/TalendAssetsApi.min.js`	3.34 kB	0 B
`./packages/assets-api/dist/TalendAssetsApi.min.js.dependencies.json`	2 B	0 B
`./packages/cmf-cqrs/dist/TalendReactCmfCqrs.js`	103 kB	0 B
`./packages/cmf-cqrs/dist/TalendReactCmfCqrs.js.dependencies.json`	672 B	0 B
`./packages/cmf-cqrs/dist/TalendReactCmfCqrs.min.js`	21.3 kB	0 B
`./packages/cmf-cqrs/dist/TalendReactCmfCqrs.min.js.dependencies.json`	695 B	0 B
`./packages/cmf-router/dist/TalendReactCmfRouter.js`	164 kB	0 B
`./packages/cmf-router/dist/TalendReactCmfRouter.js.dependencies.json`	1.25 kB	0 B
`./packages/cmf-router/dist/TalendReactCmfRouter.min.js`	13 kB	0 B
`./packages/cmf-router/dist/TalendReactCmfRouter.min.js.dependencies.json`	1.29 kB	0 B
`./packages/cmf/dist/TalendReactCmf.js`	636 kB	0 B
`./packages/cmf/dist/TalendReactCmf.js.dependencies.json`	1.31 kB	0 B
`./packages/cmf/dist/TalendReactCmf.min.js`	121 kB	0 B
`./packages/cmf/dist/TalendReactCmf.min.js.dependencies.json`	1.35 kB	0 B
`./packages/components/dist/TalendReactComponents.css`	403 kB	0 B
`./packages/components/dist/TalendReactComponents.js`	2.97 MB	0 B
`./packages/components/dist/TalendReactComponents.js.dependencies.json`	3.21 kB	0 B
`./packages/components/dist/TalendReactComponents.min.css`	210 kB	0 B
`./packages/components/dist/TalendReactComponents.min.js`	660 kB	0 B
`./packages/components/dist/TalendReactComponents.min.js.dependencies.json`	3.29 kB	0 B
`./packages/containers/dist/TalendReactContainers.css`	3.01 kB	0 B
`./packages/containers/dist/TalendReactContainers.js`	534 kB	0 B
`./packages/containers/dist/TalendReactContainers.js.dependencies.json`	1.55 kB	0 B
`./packages/containers/dist/TalendReactContainers.min.css`	1.74 kB	0 B
`./packages/containers/dist/TalendReactContainers.min.js`	103 kB	0 B
`./packages/containers/dist/TalendReactContainers.min.js.dependencies.json`	1.6 kB	0 B
`./packages/dataviz/dist/TalendReactDataviz.css`	28.9 kB	0 B
`./packages/dataviz/dist/TalendReactDataviz.js`	372 kB	0 B
`./packages/dataviz/dist/TalendReactDataviz.js.dependencies.json`	1.15 kB	0 B
`./packages/dataviz/dist/TalendReactDataviz.min.css`	12 kB	0 B
`./packages/dataviz/dist/TalendReactDataviz.min.js`	63.6 kB	0 B
`./packages/dataviz/dist/TalendReactDataviz.min.js.dependencies.json`	1.19 kB	0 B
`./packages/design-system/dist/TalendDesignSystem.css`	288 kB	0 B
`./packages/design-system/dist/TalendDesignSystem.js`	1.21 MB	0 B
`./packages/design-system/dist/TalendDesignSystem.js.dependencies.json`	1.57 kB	0 B
`./packages/design-system/dist/TalendDesignSystem.min.css`	175 kB	0 B
`./packages/design-system/dist/TalendDesignSystem.min.js`	242 kB	0 B
`./packages/design-system/dist/TalendDesignSystem.min.js.dependencies.json`	1.61 kB	0 B
`./packages/design-tokens/dist/TalendDesignTokens.css`	44.6 kB	0 B
`./packages/design-tokens/dist/TalendDesignTokens.js`	39.6 kB	0 B
`./packages/design-tokens/dist/TalendDesignTokens.js.dependencies.json`	2 B	0 B
`./packages/design-tokens/dist/TalendDesignTokens.min.css`	41.5 kB	0 B
`./packages/design-tokens/dist/TalendDesignTokens.min.js`	33.3 kB	0 B
`./packages/design-tokens/dist/TalendDesignTokens.min.js.dependencies.json`	2 B	0 B
`./packages/faceted-search/dist/TalendReactFacetedSearch.css`	37.9 kB	+88 B (0%)
`./packages/faceted-search/dist/TalendReactFacetedSearch.js.dependencies.json`	1.5 kB	0 B
`./packages/faceted-search/dist/TalendReactFacetedSearch.min.css`	17.2 kB	+80 B (0%)
`./packages/faceted-search/dist/TalendReactFacetedSearch.min.js.dependencies.json`	1.55 kB	0 B
`./packages/flow-designer/dist/TalendReactFlowDesigner.min.js`	51.5 kB	0 B
`./packages/flow-designer/dist/TalendReactFlowDesigner.min.js.dependencies.json`	1.25 kB	0 B
`./packages/forms/dist/TalendReactForms.css`	37.6 kB	0 B
`./packages/forms/dist/TalendReactForms.js`	771 kB	0 B
`./packages/forms/dist/TalendReactForms.js.dependencies.json`	1.35 kB	0 B
`./packages/forms/dist/TalendReactForms.min.css`	12.8 kB	0 B
`./packages/forms/dist/TalendReactForms.min.js`	203 kB	0 B
`./packages/forms/dist/TalendReactForms.min.js.dependencies.json`	1.39 kB	0 B
`./packages/http/dist/TalendHttp.js`	24.9 kB	0 B
`./packages/http/dist/TalendHttp.js.dependencies.json`	2 B	0 B
`./packages/http/dist/TalendHttp.min.js`	5.33 kB	0 B
`./packages/http/dist/TalendHttp.min.js.dependencies.json`	2 B	0 B
`./packages/icons/dist/bundle.js`	1.26 kB	0 B
`./packages/icons/dist/info.js`	26.1 kB	0 B
`./packages/icons/dist/react.esm.js`	585 kB	0 B
`./packages/icons/dist/react.js`	623 kB	0 B
`./packages/icons/dist/talend-icons-webfont.css`	17.4 kB	0 B
`./packages/icons/dist/talendicons.css`	334 B	0 B
`./packages/icons/dist/TalendIcons.js`	752 kB	0 B
`./packages/icons/dist/TalendIcons.js.dependencies.json`	128 B	0 B
`./packages/icons/dist/TalendIcons.min.js`	606 kB	0 B
`./packages/icons/dist/TalendIcons.min.js.dependencies.json`	131 B	0 B
`./packages/icons/dist/typeUtils.js`	14.4 kB	0 B
`./packages/jsfc/dist/index.js`	86.8 kB	0 B
`./packages/jsfc/dist/index.js.dependencies.json`	2 B	0 B
`./packages/router-bridge/dist/TalendRouterBridge.js`	134 kB	0 B
`./packages/router-bridge/dist/TalendRouterBridge.js.dependencies.json`	1.05 kB	0 B
`./packages/router-bridge/dist/TalendRouterBridge.min.js`	21 kB	0 B
`./packages/router-bridge/dist/TalendRouterBridge.min.js.dependencies.json`	1.07 kB	0 B
`./packages/sagas/dist/TalendReactSagas.js`	10.9 kB	0 B
`./packages/sagas/dist/TalendReactSagas.js.dependencies.json`	348 B	0 B
`./packages/sagas/dist/TalendReactSagas.min.js`	1.41 kB	0 B
`./packages/sagas/dist/TalendReactSagas.min.js.dependencies.json`	360 B	0 B
`./packages/stepper/dist/TalendReactStepper.css`	2.4 kB	0 B
`./packages/stepper/dist/TalendReactStepper.js`	97.4 kB	0 B
`./packages/stepper/dist/TalendReactStepper.js.dependencies.json`	1.27 kB	0 B
`./packages/stepper/dist/TalendReactStepper.min.css`	1.19 kB	0 B
`./packages/stepper/dist/TalendReactStepper.min.js`	9.64 kB	0 B
`./packages/stepper/dist/TalendReactStepper.min.js.dependencies.json`	1.31 kB	0 B
`./packages/storybook-docs/dist/globalStyles.js`	0 B	0 B	🆕
`./packages/storybook-docs/dist/globalStyles.min.css`	398 B	0 B
`./packages/storybook-docs/dist/managerStyles.js`	0 B	0 B	🆕
`./packages/storybook-docs/dist/managerStyles.min.css`	1.53 kB	0 B
`./packages/theme/dist/bootstrap.css`	172 kB	0 B
`./packages/theme/dist/bootstrap.js`	2.51 kB	0 B
`./packages/theme/dist/bootstrap.js.dependencies.json`	3 B	0 B

_{compressed-size-action}

packages/faceted-search/src/components/Badges/BadgeMenu/BadgeMenu.component.js

yyanwang · 2023-12-01T02:35:17Z

packages/faceted-search/src/components/Badges/BadgeMenu/BadgeMenu.component.test.js

+		await waitFor(() => {
+			expect(screen.getByRole('menuitem')).toBeVisible();
+		});
+		screen.logTestingPlaygroundURL();


debugging line can be removed

yyanwang · 2023-12-01T02:54:13Z

packages/faceted-search/src/components/Badges/BadgeMenu/BadgeMenu.component.js

 	const currentOperators = useMemo(() => operators, [operators]);
 	const currentOperator = operator || (currentOperators && currentOperators[0]);
+	const [isLoading, setIsLoading] = useState(true);


maybe better to set isLoading false by default? then no need for this line: https://github.com/Talend/ui/pull/5022/files#diff-9cd7307a01bfb12fcee969fa3d4f76874a44bf7dc27b1c37d95e3157942ee263R51

yyanwang · 2023-12-01T02:57:41Z

packages/faceted-search/src/components/Badges/BadgeMenu/BadgeMenuForm.component.js

@@ -119,6 +127,8 @@ const BadgeMenuForm = ({
 						type="submit"
 						label={t('APPLY', { defaultValue: 'Apply' })}
 						bsStyle="info"
+						disabled={rest.isLoading}
+						inProgress={rest.isLoading}


IMO no need set inProgress to true when loading options, just disable submit button is enough. set inProgress to true when it's submitting.

yyanwang · 2023-12-01T03:02:02Z

packages/faceted-search/src/components/facetedSearch.propTypes.js

@@ -39,6 +39,7 @@ const badgeFacetedPropTypes = PropTypes.shape({
 		isInCreation: PropTypes.bool,
 		entitiesPerBadge: PropTypes.string,
 		operators: PropTypes.arrayOf(PropTypes.string),
+		isLoading: PropTypes.bool,


Do we need to add isLoading to metadata?

feat(TDOPS-4789/facetedSearch): callback support for BadgeMenu

6e9ff1d

ybaskaran temporarily deployed to pull_request_unsafe November 30, 2023 14:31 — with GitHub Actions Inactive

inna-i reviewed Nov 30, 2023

View reviewed changes

packages/faceted-search/src/components/Badges/BadgeMenu/BadgeMenu.component.js Outdated Show resolved Hide resolved

fix: isEmpty import

034e6c6

inna-i temporarily deployed to pull_request_unsafe November 30, 2023 16:33 — with GitHub Actions Inactive

inna-i had a problem deploying to pull_request_unsafe November 30, 2023 16:33 — with GitHub Actions Error

inna-i approved these changes Nov 30, 2023

View reviewed changes

Merge branch 'master' into feat/TDOPS-4789/callback-for-badge-menu

86de403

inna-i temporarily deployed to pull_request_unsafe November 30, 2023 16:33 — with GitHub Actions Inactive

inna-i temporarily deployed to pull_request_unsafe November 30, 2023 16:34 — with GitHub Actions Inactive

inna-i had a problem deploying to pull_request_unsafe November 30, 2023 16:34 — with GitHub Actions Failure

yyanwang reviewed Dec 1, 2023

View reviewed changes

feat(TDOPS-4789/facetedSearch): callback support for BadgeMenu

ab217a4

ybaskaran temporarily deployed to pull_request_unsafe December 5, 2023 08:10 — with GitHub Actions Inactive

ybaskaran had a problem deploying to pull_request_unsafe December 5, 2023 08:10 — with GitHub Actions Error

feat(TDOPS-4789/facetedSearch): callback support for BadgeMenu

5fe4f63

ybaskaran temporarily deployed to pull_request_unsafe December 5, 2023 08:23 — with GitHub Actions Inactive

ybaskaran had a problem deploying to pull_request_unsafe December 5, 2023 08:23 — with GitHub Actions Error

Merge branch 'master' into feat/TDOPS-4789/callback-for-badge-menu

2519ec7

ybaskaran temporarily deployed to pull_request_unsafe December 5, 2023 08:24 — with GitHub Actions Inactive

yyanwang approved these changes Dec 5, 2023

View reviewed changes

ybaskaran merged commit fc7d4e2 into master Dec 5, 2023
12 checks passed

ybaskaran deleted the feat/TDOPS-4789/callback-for-badge-menu branch December 5, 2023 08:40

ybaskaran had a problem deploying to pull_request_unsafe December 5, 2023 08:40 — with GitHub Actions Failure

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(TDOPS-4789/facetedSearch): callback support for BadgeMenu #5022

feat(TDOPS-4789/facetedSearch): callback support for BadgeMenu #5022

ybaskaran commented Nov 30, 2023

github-actions bot commented Nov 30, 2023

github-actions bot commented Nov 30, 2023 •

edited

Loading

github-actions bot commented Nov 30, 2023 •

edited

Loading

yyanwang Dec 1, 2023

ybaskaran Dec 5, 2023

yyanwang Dec 1, 2023

ybaskaran Dec 5, 2023

yyanwang Dec 1, 2023

ybaskaran Dec 5, 2023

yyanwang Dec 1, 2023

ybaskaran Dec 5, 2023

feat(TDOPS-4789/facetedSearch): callback support for BadgeMenu #5022

feat(TDOPS-4789/facetedSearch): callback support for BadgeMenu #5022

Conversation

ybaskaran commented Nov 30, 2023

github-actions bot commented Nov 30, 2023

github-actions bot commented Nov 30, 2023 • edited Loading

github-actions bot commented Nov 30, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Nov 30, 2023 •

edited

Loading

github-actions bot commented Nov 30, 2023 •

edited

Loading