Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade testing library #4954

Merged
merged 32 commits into from
Nov 29, 2023

Conversation

jmfrancois
Copy link
Collaborator

@jmfrancois jmfrancois commented Oct 24, 2023

What is the problem this PR is trying to solve?

we are on testing-library for react 17.
So we have logs in tests saying that render is done with the compatibility layer.

Warning: ReactDOM.render is no longer supported in React 18. Use createRoot instead. Until you switch to the new API, your app will behave as if it's running React 17. Learn more: https://reactjs.org/link/switch-to-createroot

What is the chosen solution to this problem?

upgrade testing-library:

  • build
  • test

Please check if the PR fulfills these requirements

  • The PR have used yarn changeset to a request a release from the CI if wanted.
  • The PR commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features) And non reg done before need review
  • Docs have been added / updated (for bug fixes / features)
  • Related design / discussions / pages (not in jira), if any, are all linked or available in the PR

[ ] This PR introduces a breaking change

@jmfrancois jmfrancois temporarily deployed to pull_request_unsafe October 24, 2023 09:26 — with GitHub Actions Inactive
@jmfrancois jmfrancois temporarily deployed to pull_request_unsafe October 24, 2023 09:26 — with GitHub Actions Inactive
@jmfrancois jmfrancois temporarily deployed to pull_request_unsafe October 24, 2023 09:31 — with GitHub Actions Inactive
@jmfrancois jmfrancois temporarily deployed to pull_request_unsafe October 24, 2023 09:32 — with GitHub Actions Inactive
@jmfrancois jmfrancois temporarily deployed to pull_request_unsafe October 24, 2023 09:47 — with GitHub Actions Inactive
@jmfrancois jmfrancois temporarily deployed to pull_request_unsafe October 24, 2023 09:47 — with GitHub Actions Inactive
@jmfrancois jmfrancois temporarily deployed to pull_request_unsafe October 24, 2023 09:47 — with GitHub Actions Inactive
@jmfrancois jmfrancois temporarily deployed to pull_request_unsafe October 24, 2023 09:47 — with GitHub Actions Inactive
@jmfrancois jmfrancois temporarily deployed to pull_request_unsafe October 24, 2023 09:47 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

4954

:octocat: Demo is available here

@github-actions
Copy link
Contributor

github-actions bot commented Oct 24, 2023

Size Change: -36.4 kB (0%)

Total Size: 13.4 MB

Filename Size Change
./packages/components/dist/TalendReactComponents.js 2.97 MB -9.99 kB (0%)
./packages/components/dist/TalendReactComponents.min.js 660 kB -1.97 kB (0%)
./packages/containers/dist/TalendReactContainers.js 534 kB -4.62 kB (-1%)
./packages/containers/dist/TalendReactContainers.min.js 103 kB -1.42 kB (-1%)
./packages/design-system/dist/TalendDesignSystem.js 1.18 MB -4.35 kB (0%)
./packages/design-system/dist/TalendDesignSystem.min.js 236 kB -1.47 kB (-1%)
./packages/faceted-search/dist/TalendReactFacetedSearch.js 448 kB -4.3 kB (-1%)
./packages/faceted-search/dist/TalendReactFacetedSearch.min.js 101 kB -1.48 kB (-1%)
./packages/forms/dist/TalendReactForms.js 771 kB -5.37 kB (-1%)
./packages/forms/dist/TalendReactForms.min.js 203 kB -1.49 kB (-1%)
ℹ️ View Unchanged
Filename Size Change
./packages/assets-api/dist/TalendAssetsApi.js 7.21 kB 0 B
./packages/assets-api/dist/TalendAssetsApi.js.dependencies.json 2 B 0 B
./packages/assets-api/dist/TalendAssetsApi.min.js 3.34 kB 0 B
./packages/assets-api/dist/TalendAssetsApi.min.js.dependencies.json 2 B 0 B
./packages/cmf-cqrs/dist/TalendReactCmfCqrs.js 103 kB 0 B
./packages/cmf-cqrs/dist/TalendReactCmfCqrs.js.dependencies.json 672 B 0 B
./packages/cmf-cqrs/dist/TalendReactCmfCqrs.min.js 21.3 kB 0 B
./packages/cmf-cqrs/dist/TalendReactCmfCqrs.min.js.dependencies.json 695 B 0 B
./packages/cmf-router/dist/TalendReactCmfRouter.js 164 kB 0 B
./packages/cmf-router/dist/TalendReactCmfRouter.js.dependencies.json 1.25 kB 0 B
./packages/cmf-router/dist/TalendReactCmfRouter.min.js 13 kB 0 B
./packages/cmf-router/dist/TalendReactCmfRouter.min.js.dependencies.json 1.29 kB 0 B
./packages/cmf/dist/TalendReactCmf.js 636 kB 0 B
./packages/cmf/dist/TalendReactCmf.js.dependencies.json 1.31 kB 0 B
./packages/cmf/dist/TalendReactCmf.min.js 121 kB 0 B
./packages/cmf/dist/TalendReactCmf.min.js.dependencies.json 1.35 kB 0 B
./packages/components/dist/TalendReactComponents.css 403 kB 0 B
./packages/components/dist/TalendReactComponents.js.dependencies.json 3.21 kB 0 B
./packages/components/dist/TalendReactComponents.min.css 210 kB 0 B
./packages/components/dist/TalendReactComponents.min.js.dependencies.json 3.29 kB 0 B
./packages/containers/dist/TalendReactContainers.css 3.01 kB 0 B
./packages/containers/dist/TalendReactContainers.js.dependencies.json 1.55 kB 0 B
./packages/containers/dist/TalendReactContainers.min.css 1.74 kB 0 B
./packages/containers/dist/TalendReactContainers.min.js.dependencies.json 1.6 kB 0 B
./packages/dataviz/dist/TalendReactDataviz.css 28.9 kB 0 B
./packages/dataviz/dist/TalendReactDataviz.js 372 kB 0 B
./packages/dataviz/dist/TalendReactDataviz.js.dependencies.json 1.15 kB 0 B
./packages/dataviz/dist/TalendReactDataviz.min.css 12 kB 0 B
./packages/dataviz/dist/TalendReactDataviz.min.js 63.6 kB 0 B
./packages/dataviz/dist/TalendReactDataviz.min.js.dependencies.json 1.19 kB 0 B
./packages/design-system/dist/TalendDesignSystem.css 282 kB 0 B
./packages/design-system/dist/TalendDesignSystem.js.dependencies.json 1.43 kB 0 B
./packages/design-system/dist/TalendDesignSystem.min.css 173 kB 0 B
./packages/design-system/dist/TalendDesignSystem.min.js.dependencies.json 1.48 kB 0 B
./packages/design-tokens/dist/TalendDesignTokens.css 44.6 kB 0 B
./packages/design-tokens/dist/TalendDesignTokens.js 39.6 kB 0 B
./packages/design-tokens/dist/TalendDesignTokens.js.dependencies.json 2 B 0 B
./packages/design-tokens/dist/TalendDesignTokens.min.css 41.5 kB 0 B
./packages/design-tokens/dist/TalendDesignTokens.min.js 33.3 kB 0 B
./packages/design-tokens/dist/TalendDesignTokens.min.js.dependencies.json 2 B 0 B
./packages/faceted-search/dist/TalendReactFacetedSearch.css 37.8 kB 0 B
./packages/faceted-search/dist/TalendReactFacetedSearch.js.dependencies.json 1.5 kB 0 B
./packages/faceted-search/dist/TalendReactFacetedSearch.min.css 17.1 kB 0 B
./packages/faceted-search/dist/TalendReactFacetedSearch.min.js.dependencies.json 1.55 kB 0 B
./packages/flow-designer/dist/TalendReactFlowDesigner.min.js 51.5 kB 0 B
./packages/flow-designer/dist/TalendReactFlowDesigner.min.js.dependencies.json 1.25 kB 0 B
./packages/forms/dist/TalendReactForms.css 37.6 kB 0 B
./packages/forms/dist/TalendReactForms.js.dependencies.json 1.35 kB 0 B
./packages/forms/dist/TalendReactForms.min.css 12.8 kB 0 B
./packages/forms/dist/TalendReactForms.min.js.dependencies.json 1.39 kB 0 B
./packages/http/dist/TalendHttp.js 24.9 kB 0 B
./packages/http/dist/TalendHttp.js.dependencies.json 2 B 0 B
./packages/http/dist/TalendHttp.min.js 5.33 kB 0 B
./packages/http/dist/TalendHttp.min.js.dependencies.json 2 B 0 B
./packages/icons/dist/bundle.js 1.26 kB 0 B
./packages/icons/dist/info.js 26.1 kB 0 B
./packages/icons/dist/react.esm.js 585 kB 0 B
./packages/icons/dist/react.js 623 kB 0 B
./packages/icons/dist/talend-icons-webfont.css 17.4 kB 0 B
./packages/icons/dist/talendicons.css 334 B 0 B
./packages/icons/dist/TalendIcons.js 752 kB 0 B
./packages/icons/dist/TalendIcons.js.dependencies.json 128 B 0 B
./packages/icons/dist/TalendIcons.min.js 606 kB 0 B
./packages/icons/dist/TalendIcons.min.js.dependencies.json 131 B 0 B
./packages/icons/dist/typeUtils.js 14.4 kB 0 B
./packages/jsfc/dist/index.js 86.8 kB 0 B
./packages/jsfc/dist/index.js.dependencies.json 2 B 0 B
./packages/router-bridge/dist/TalendRouterBridge.js 134 kB 0 B
./packages/router-bridge/dist/TalendRouterBridge.js.dependencies.json 1.05 kB 0 B
./packages/router-bridge/dist/TalendRouterBridge.min.js 21 kB 0 B
./packages/router-bridge/dist/TalendRouterBridge.min.js.dependencies.json 1.07 kB 0 B
./packages/sagas/dist/TalendReactSagas.js 10.9 kB 0 B
./packages/sagas/dist/TalendReactSagas.js.dependencies.json 348 B 0 B
./packages/sagas/dist/TalendReactSagas.min.js 1.41 kB 0 B
./packages/sagas/dist/TalendReactSagas.min.js.dependencies.json 360 B 0 B
./packages/stepper/dist/TalendReactStepper.css 2.4 kB 0 B
./packages/stepper/dist/TalendReactStepper.js 97.4 kB 0 B
./packages/stepper/dist/TalendReactStepper.js.dependencies.json 1.27 kB 0 B
./packages/stepper/dist/TalendReactStepper.min.css 1.19 kB 0 B
./packages/stepper/dist/TalendReactStepper.min.js 9.64 kB 0 B
./packages/stepper/dist/TalendReactStepper.min.js.dependencies.json 1.31 kB 0 B
./packages/storybook-docs/dist/globalStyles.js 0 B 0 B 🆕
./packages/storybook-docs/dist/globalStyles.min.css 398 B 0 B
./packages/storybook-docs/dist/managerStyles.js 0 B 0 B 🆕
./packages/storybook-docs/dist/managerStyles.min.css 1.53 kB 0 B
./packages/theme/dist/bootstrap.css 172 kB 0 B
./packages/theme/dist/bootstrap.js 2.51 kB 0 B
./packages/theme/dist/bootstrap.js.dependencies.json 3 B 0 B

compressed-size-action

@jmfrancois jmfrancois temporarily deployed to pull_request_unsafe October 24, 2023 13:40 — with GitHub Actions Inactive
@jmfrancois jmfrancois temporarily deployed to pull_request_unsafe October 24, 2023 13:40 — with GitHub Actions Inactive
@jmfrancois jmfrancois temporarily deployed to pull_request_unsafe October 24, 2023 13:40 — with GitHub Actions Inactive
@jmfrancois jmfrancois temporarily deployed to pull_request_unsafe October 24, 2023 13:40 — with GitHub Actions Inactive
@jmfrancois jmfrancois temporarily deployed to pull_request_unsafe October 24, 2023 13:40 — with GitHub Actions Inactive
@jmainguytalend jmainguytalend self-assigned this Nov 6, 2023
@romainseb romainseb enabled auto-merge (squash) November 29, 2023 08:01
@romainseb romainseb merged commit 24bcb17 into master Nov 29, 2023
13 checks passed
@romainseb romainseb deleted the jmfrancois/chore/upgrade-testing-library branch November 29, 2023 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants