Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ARCH-720/components): use design tokens #4795

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
63 commits
Select commit Hold shift + click to select a range
3deb1ab
feat: HeaderBar on design tokens
jmfrancois Jul 11, 2023
e445cfd
feat: add storybook toolbar for DS tokens
jmfrancois Jul 11, 2023
0660267
feat: ActionBar
jmfrancois Jul 11, 2023
43891e5
feat: CollapsiblePanel
jmfrancois Jul 11, 2023
57ac088
chore: Drawer
jmfrancois Jul 12, 2023
997a5da
chore: use tokens
jmfrancois Jul 12, 2023
597d269
chore: Datalist and Typeahead
jmfrancois Jul 12, 2023
b9a3e1d
fix: theme buttons
jmfrancois Jul 12, 2023
1271eab
chore: Date/Time pickers
jmfrancois Jul 12, 2023
0193e02
doc: up
jmfrancois Jul 12, 2023
0957960
test: update snapshots
jmfrancois Jul 12, 2023
72d7cb9
test: update
jmfrancois Jul 12, 2023
d0c48b6
feat: Enumeration
jmfrancois Jul 12, 2023
5c36ca4
feat: ResourcePicker
jmfrancois Jul 12, 2023
85a5710
feat: Slider
jmfrancois Jul 12, 2023
01b2f81
feat: Toggle
jmfrancois Jul 12, 2023
8437f97
chore: guidedtour
jmfrancois Jul 12, 2023
893f110
feat: Tooltip
jmfrancois Jul 12, 2023
7074bcc
feat: Badge
jmfrancois Jul 12, 2023
64778bb
feat: Skeleton
jmfrancois Jul 12, 2023
b95e02e
feat: SubHeaderBar
jmfrancois Jul 12, 2023
6324459
fix: Enumeration
jmfrancois Jul 13, 2023
07c1d5c
fix: ListView
jmfrancois Jul 13, 2023
c67ad50
feat: ActionIconToggle
jmfrancois Jul 13, 2023
8cd333a
fix: ResourceList toolbar
jmfrancois Jul 13, 2023
b7706ce
fix: theme buttons
jmfrancois Jul 13, 2023
949c183
chore: cleanup
jmfrancois Jul 13, 2023
e714809
chore: Notification
jmfrancois Jul 17, 2023
0da7704
progress and status
jmfrancois Jul 17, 2023
00353f6
chore: cleanup
jmfrancois Jul 17, 2023
825d11f
feat: legacy datetime picker
jmfrancois Jul 17, 2023
474ca96
feat: jsonschema renderer and skiplinks
jmfrancois Jul 17, 2023
f8beb29
chore: multiselect
jmfrancois Jul 17, 2023
1cf73fe
chore: AppLoader
jmfrancois Jul 17, 2023
8ba913b
feat: DataViewer
jmfrancois Jul 17, 2023
b43f3cd
PieChart
jmfrancois Jul 17, 2023
8c0c8d6
feat: ObjectViewer
jmfrancois Jul 17, 2023
ba7a20b
fix: ObjectViewer
jmfrancois Jul 17, 2023
461841a
feat: TreeView
jmfrancois Jul 17, 2023
6e8496c
EditableText
jmfrancois Jul 17, 2023
0d493b2
fix: FilterBar
jmfrancois Jul 17, 2023
2e5936f
FormatValue
jmfrancois Jul 17, 2023
3425b32
fix: lint
jmfrancois Jul 17, 2023
cfeb668
feat: List+ toolbar
jmfrancois Jul 17, 2023
b03a38d
feat: List
jmfrancois Jul 17, 2023
73d9b3a
RadarChart
jmfrancois Jul 17, 2023
c76af87
test: fix snap
jmfrancois Jul 18, 2023
b3cc1d0
fix: dove-gray
jmfrancois Jul 18, 2023
4f2fed6
fix: remove scooter
jmfrancois Jul 18, 2023
344bf48
chore: remove gray
jmfrancois Jul 18, 2023
7bd05d0
chore: remove previous black/white variables
jmfrancois Jul 18, 2023
247fcd5
chore: some more cleanup
jmfrancois Jul 18, 2023
63d5a61
Merge branch 'jmfrancois/feat/bootstrap-theme-tokens' into jmfrancois…
jmfrancois Jul 19, 2023
b7654cc
Update _buttons.scss
jmfrancois Jul 19, 2023
b647a72
Update package.json
jmfrancois Jul 19, 2023
98113d9
chore: add missing deps
jmfrancois Jul 19, 2023
354c969
fix: SidePanel
jmfrancois Jul 20, 2023
f2a2ed7
fix: SidePanel for the theme
jmfrancois Jul 20, 2023
0e490b7
test: update snapshot
jmfrancois Jul 20, 2023
0ae4fe4
Merge branch 'jmfrancois/feat/bootstrap-theme-tokens' into jmfrancois…
jmfrancois Jul 20, 2023
81623c3
test: fix
jmfrancois Jul 21, 2023
08b3075
Merge branch 'jmfrancois/feat/bootstrap-theme-tokens' into jmfrancois…
jmfrancois Jul 21, 2023
c739f74
feat(ARCH-720): use design-tokens (#4808)
jmfrancois Jul 24, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/angry-moles-happen.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@talend/react-faceted-search': major
---

feat: use design-tokens for colors
5 changes: 5 additions & 0 deletions .changeset/flat-crabs-visit.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@talend/react-dataviz': major
---

feat: colors now use design-tokens
5 changes: 5 additions & 0 deletions .changeset/shaggy-islands-grow.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@talend/scripts-config-storybook-lib': minor
---

feat: add design token update in the toolbar
5 changes: 5 additions & 0 deletions .changeset/strange-ligers-bathe.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@talend/react-forms': major
---

All colors are now based on design-tokens
43 changes: 43 additions & 0 deletions .changeset/wet-dolls-compare.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
---
'@talend/react-components': major
---

Style now use design tokens instead of bootstrap sass variables

We have updated the following components:

* ActionBar
* ActionIconToggle
* AppLoader
* Badge
* CollapsiblePanel
* Datalist
* DataViewer
* DateTimePickers + Legacy
* Drawer
* EditableText
* Enumeration (bug on buttons)
* FilterBar
* FormatValue
* GuidedTour
* GridLayout aka Dashboard
* HeaderBar
* List (Virtualized and Composition)
* ListView
* MultiSelect
* Notification
* ObjectViewer
* PieChart
* Progress
* RadarChart
* ResourceList
* ResourcePicker
* RichLayout
* Skeleton
* Slider
* Status
* SubHeaderBar
* Toggle
* Tooltip
* TreeView
* Typeahead
1 change: 1 addition & 0 deletions packages/components/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@
"dependencies": {
"@popperjs/core": "^2.11.8",
"@talend/bootstrap-theme": "^7.0.1",
"@talend/design-tokens": "^2.7.3",
"@talend/react-a11y": "^1.1.0",
"@talend/icons": "^6.58.1",
"@talend/utils": "^2.5.1",
Expand Down
10 changes: 5 additions & 5 deletions packages/components/src/ActionBar/ActionBar.module.scss
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
@use '~@talend/bootstrap-theme/src/theme/guidelines' as *;
@use '~@talend/design-tokens/lib/tokens';

$tc-action-bar-background-color: $wild-sand !default;
$tc-action-bar-margin: $padding-small $padding-large $padding-small 0 !default;

.tc-actionbar-container {
padding: 0 $padding-small;
background: $tc-action-bar-background-color;
background: tokens.$coral-color-neutral-background-medium;
width: 100%;
display: flex;

Expand Down Expand Up @@ -61,19 +61,19 @@ $tc-action-bar-margin: $padding-small $padding-large $padding-small 0 !default;

&:global(.separated)::after {
content: '|';
color: $silver;
color: tokens.$coral-color-neutral-text;
margin-left: $padding-large;
}
}

:global(.divider) {
color: $silver;
color: tokens.$coral-color-neutral-text;
margin-right: $padding-normal;
}
}

:global(.modal-footer) .tc-actionbar-container {
background-color: $wild-sand;
background-color: transparent;

.navbar-left > *,
.navbar-center > *,
Expand Down
4 changes: 4 additions & 0 deletions packages/components/src/ActionList/ActionList.component.js
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,9 @@ function ActionList(props) {
theme['tc-action-list'],
'tc-action-list',
className,
{
'nav-inverse': props.reverse,
},
)}
>
{actions.map((action, index) => (
Expand Down Expand Up @@ -135,6 +138,7 @@ if (process.env.NODE_ENV !== 'production') {
onSelect: PropTypes.func,
selected: actionPropType,
className: PropTypes.string,
reverse: PropTypes.bool,
};
}

Expand Down
13 changes: 13 additions & 0 deletions packages/components/src/ActionList/ActionList.stories.js
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,19 @@ export const Default = () => (
</div>
);

export const Reverse = () => (
<div style={{ display: 'inline-table' }}>
<ActionList
id="context"
actions={actions}
onSelect={action('onItemSelect')}
onToggleDock={action('onToggleDock')}
tooltipPlacement="top"
reverse
/>
</div>
);

export const WithCustomClassNames = () => (
<div>
<p>You can add your custom classnames to the container and items</p>
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
@use '~@talend/bootstrap-theme/src/theme/guidelines' as *;
@use '~@talend/design-tokens/lib/tokens';

$tc-dropdown-loader-padding: $padding-small !default;
$tc-dropdown-button-right-padding: 0.8rem;
Expand Down Expand Up @@ -54,7 +55,7 @@ $tc-dropdown-button-right-padding: 0.8rem;
margin: -$tc-dropdown-loader-padding 0;
padding: $tc-dropdown-loader-padding 0;
text-align: center;
background: $concrete;
background: tokens.$coral-color-neutral-background-medium;

:global(.divider) + & {
margin: -($tc-dropdown-loader-padding - 1px) 0;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
@use '~@talend/bootstrap-theme/src/theme/guidelines' as *;
@use '~@talend/design-tokens/lib/tokens';

$tc-icon-toggle-size: 2.4rem !default;
$tc-icon-toggle-icon-size: $svg-sm-size !default;
$tc-icon-toggle-border: 1px solid $gray;
$tc-icon-toggle-border: tokens.$coral-border-s-solid tokens.$coral-color-neutral-border !default;
$tc-icon-toggle-tick-size: 12px !default;
$tc-icon-toggle-tick-border: 1px solid $white;

@mixin tc-icon-toggle($btn-size: $tc-icon-toggle-size, $icon-size: $tc-icon-toggle-icon-size) {
height: $btn-size;
Expand Down Expand Up @@ -32,7 +32,7 @@ $tc-icon-toggle-tick-border: 1px solid $white;
padding: 0;

svg {
color: $gray;
color: tokens.$coral-color-neutral-icon-weak;
}

&,
Expand All @@ -43,37 +43,41 @@ $tc-icon-toggle-tick-border: 1px solid $white;
&[disabled] {
&:hover,
&:focus {
border-color: $scooter;
border-color: tokens.$coral-color-accent-text;

svg {
color: $scooter;
color: tokens.$coral-color-accent-text;
}
}
}

&:hover,
&:active {
box-shadow: none;
border-color: $scooter;
border-color: tokens.$coral-color-accent-text;
background-color: transparent;

svg {
color: $scooter;
color: tokens.$coral-color-accent-text;
}
}

&.active {
background-color: $brand-primary;
border-color: $brand-primary;
background-color: tokens.$coral-color-accent-background-strong;
border-color: tokens.$coral-color-accent-background;

svg {
color: white;
color: tokens.$coral-color-accent-text-weak;
}

&:hover:not([disabled]),
&:active {
background-color: $scooter;
border-color: $scooter;
background-color: tokens.$coral-color-accent-background-hover;
border-color: tokens.$coral-color-accent-background-hover;

svg {
color: tokens.$coral-color-accent-text;
}
}
}

Expand All @@ -85,7 +89,7 @@ $tc-icon-toggle-tick-border: 1px solid $white;
border-radius: calc(#{$tc-icon-toggle-tick-size} / 2);
right: -0.4rem;
top: -0.4rem;
background: $scooter;
border: $tc-icon-toggle-tick-border;
background: tokens.$coral-color-accent-text;
border: tokens.$coral-border-s-solid tokens.$coral-color-neutral-border-weak;
}
}
2 changes: 2 additions & 0 deletions packages/components/src/AppLoader/constant.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ body {
height: 100vh;
width: 100vw;
background: #f6f6f6;
background: var(--coral-color-neutral-background-medium, #f6f6f6);
}

.tc-app-loader-icon {
Expand Down Expand Up @@ -40,6 +41,7 @@ body {
height: 100%;
opacity: 0;
border-color: #ababab;
border-color: var(--coral-color-neutral-border, #ababab);
opacity: 1;
animation: app-loader-spin 5332ms cubic-bezier(.4, 0, .2, 1) infinite both;
}
Expand Down
5 changes: 3 additions & 2 deletions packages/components/src/AppSwitcher/AppSwitcher.module.scss
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
@use '~@talend/bootstrap-theme/src/theme/guidelines' as *;
@use '~@talend/design-tokens/lib/tokens';

.tc-app-switcher {
:global(.tc-svg-icon:first-child) {
Expand All @@ -19,7 +20,7 @@
display: block;
width: 1px;
height: $font-size-large;
background-color: $white;
background-color: tokens.$coral-color-neutral-background;
}

&.hasIcon {
Expand All @@ -35,7 +36,7 @@
height: $navbar-brand-logo-height;
width: $navbar-brand-logo-height;
background-repeat: no-repeat;
background-color: white;
background-color: tokens.$coral-color-neutral-background;
}
}

Expand Down
Loading
Loading