fix(script-core): fix bin resolve issue on windows (#5025)

* fix(script-core): fix bin resolve issue on windows * fix on jest also * even more
Talend · Dec 1, 2023 · f69c72b · f69c72b
1 parent 6c2df2b
commit f69c72b
Show file tree

Hide file tree

Showing 6 changed files with 14 additions and 14 deletions.
diff --git a/.changeset/fresh-kiwis-grin.md b/.changeset/fresh-kiwis-grin.md
@@ -0,0 +1,5 @@
+---
+'@talend/scripts-core': patch
+---
+
+Fixed issue with scripts that could not resolve bin path on windows
diff --git a/tools/scripts-core/src/scripts/build-lib.js b/tools/scripts-core/src/scripts/build-lib.js
@@ -53,7 +53,7 @@ export default async function build(env, presetApi, unsafeOptions) {
 			console.log('Compiling with babel...');
 			utils.process
 				.spawn(
-					new URL(import.meta.resolve('@babel/cli/bin/babel.js')).pathname,
+					utils.path.resolveBin('babel'),
 					[
 						'--config-file',
 						babelConfigPath,
@@ -105,8 +105,7 @@ export default async function build(env, presetApi, unsafeOptions) {
 				console.log('Building with tsc');
 			}
 
-			const tsc = new URL(import.meta.resolve('typescript/bin/tsc')).pathname;
-			console.log('####TSC', args);
+			const tsc = utils.path.resolveBin('tsc');
 			utils.process
 				.spawn(tsc, args, { stdio: 'inherit', env })
 				.then(tscSpawn => {

diff --git a/tools/scripts-core/src/scripts/build.js b/tools/scripts-core/src/scripts/build.js
@@ -8,7 +8,7 @@ export default async function build(env, _, options) {
 	const packageType = utils.pkg.getPackageType();
 	if (packageType.isApp) {
 		return utils.process.spawn(
-			new URL(import.meta.resolve('webpack/bin/webpack.js')).pathname,
+			utils.path.resolveBin('webpack'),
 			[
 				'--config',
 				utils.path.hereRelative(

diff --git a/tools/scripts-core/src/scripts/lint.js b/tools/scripts-core/src/scripts/lint.js
@@ -101,14 +101,10 @@ async function lintStyle(env, presetApi, options) {
 		}
 	}
 
-	return utils.process.spawn(
-		new URL(import.meta.resolve('stylelint/bin/stylelint.mjs')).pathname,
-		args,
-		{
-			stdio: 'inherit',
-			env,
-		},
-	);
+	return utils.process.spawn(utils.path.resolveBin('stylelint'), args, {
+		stdio: 'inherit',
+		env,
+	});
 }
 
 export default async function lint(env, presetApi, options) {

diff --git a/tools/scripts-core/src/scripts/start.js b/tools/scripts-core/src/scripts/start.js
@@ -7,7 +7,7 @@ export default async function start(env, _, options) {
 
 	if (packageType.isApp) {
 		return utils.process.spawn(
-			new URL(import.meta.resolve('webpack/bin/webpack.js')).pathname,
+			utils.path.resolveBin('webpack'),
 			[
 				'serve',
 				'--config',

diff --git a/tools/scripts-core/src/scripts/test.js b/tools/scripts-core/src/scripts/test.js
@@ -33,7 +33,7 @@ export default async function test(env, presetApi, options) {
 		getUserConfigFile('jest.config.js') || path.join(configPath, 'jest.config.js');
 
 	return utils.process.spawn(
-		new URL(import.meta.resolve('jest-cli/bin/jest')).pathname,
+		utils.path.resolveBin('jest'),
 		['--config', jestConfigPath].concat(options),
 		{
 			stdio: 'inherit',