[SECURITY] Add a name validator matching keycloak constraints #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
buchmarv
commented
Oct 4, 2024
•
buchmarv
commented
- To see the specific tasks where the Asana app for GitHub is being used, see below:
- https://app.asana.com/0/0/1207643369134611
|
The regex is derived from https://github.com/keycloak/keycloak/blob/main/services/src/main/java/org/keycloak/userprofile/validator/PersonNameProhibitedCharactersValidator.java#L42 and needed some adjustments as it was not compatible with PCRE. |
| 'null' => [null, true], | ||
| 'empty string' => ['', true], | ||
| 'Valid name' => ['Dscherêmy-Pasquàlle Gucci', true], | ||
| 'Valid name 2' => ['X Æ A-12', true], |
There was a problem hiding this comment.
I see what you did there.
| 'Opening square bracket' => ['[Harald', false], | ||
| 'Closing square bracket' => ['Sieglinde]', false], | ||
| 'Percent' => ['100% creative', false], | ||
| 'Exclamation mark' => ['My name\'s not Rick!', false], |
There was a problem hiding this comment.
Missed chance: I am Pickle Rick!
There was a problem hiding this comment.
Ahh, never watched it. 😬
| 'Exclamation mark' => ['My name\'s not Rick!', false], | ||
| 'Hash' => ['#Snoop', false], | ||
| 'Question mark' => ['Am I supposed to put my name in here?', false], | ||
| 'Paragraph' => ['§ 307 StGB', false], |
| 'Semicolon' => ['return true;', false], | ||
| 'Asterisk' => ['Ein *, der deinen Namen trägt.', false], | ||
| 'Tilde' => ['~~~oO Andiii Oo~~~', false], | ||
| 'Pipe' => ['Roddy |er', false], |
andreaskienast
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.