feat(room-plan): smart spaces integration #334
Conversation
mschwrdtnr
added
feature
|
Preview Environment ready at https://pr-334.demo-phonebook.me |
| @@ -16,6 +16,7 @@ We use [traefik](https://traefik.io/) under the hood. | |||
| host: &host 'example.com' | |||
| contactUrl: '<Your Contact Url, maybe an issue tracker?>' | |||
| roomPlanningToolUrl: '<Url to your Room Planning Tool>' | |||
| smartSpacesUrl: '<Url to your Smart Spaces Site>' | |||
There was a problem hiding this comment.
Can you add the variable in the table below?
| <div class="svg-container" [style.display]="floorPlanSVG ? 'block' : 'none'" #floorplanSVG></div> | ||
| <!-- Container for Smart Spaces --> | ||
| <ng-container *ngIf="floorplan == 'DDR7HausD24' && runtimeEnvironment.smartSpacesUrl"> | ||
| <mat-slide-toggle |
There was a problem hiding this comment.
I think we should display it straight away, no asking or toggle required. Just fallback to the old roomplan if there is an error.
|
@mschwrdtnr how is it going? |
|
For adding something to the |
DanielHabenicht
changed the title
On my TODO-List, but will still not work because the known errors in smart-spaces application. |
|
are there any updates to this? can someone continue the work? |
|
@paule96 It still can't be implemented even if we resolve @DanielHabenicht suggestions, because the smart spaces application is not working for now. I wrote the accountable an email and he want to give me an info about the current state of his application. |
This is a preparation for the integration of smart spaces.
Currently it will be only shown for floor "DDR7HausD24". I know that this is not the best solution but it's just a small test-case.
To test this pr you can remove
*ngIfin the ng-container and add a smartspaces url toruntime-environment.ts.Before this solutions goes live we need to add the url for smart-spaces into our environment-variables
Do not merge until the error on the smartspaces site is fixed.