Feat/add picture service #161

DanielHabenicht · 2019-08-12T11:46:24Z

Resolves #53

Use Microsoft.AspNetCore.Mvc.Versioning
- https://github.com/microsoft/aspnet-api-versioning/wiki/Swashbuckle-Integration
- https://github.com/microsoft/aspnet-api-versioning/tree/master/samples/aspnetcore/SwaggerSample
Use authorization
- secure by default -> AllowAnonymous on routes that are public, not the other way around
Add Build

DanielHabenicht · 2019-08-12T11:47:53Z

@kirkone There is you working example for reference ;)

DanielHabenicht · 2019-08-12T12:02:04Z

Preview Environment ready at https://52.164.242.212

...onebook.Backend.PictureService/Phonebook.Backend.PictureService/BackgroundTasks/PurgeTask.cs

...nd.PictureService/Phonebook.Backend.PictureService/Controllers/EmployeePicturesController.cs

...nebook.Backend.PictureService/Phonebook.Backend.PictureService/Controllers/UserController.cs

...nd.PictureService/Phonebook.Backend.PictureService/Controllers/EmployeePicturesController.cs

- and add spellchecker to recommended extensions

Create method to get People from PersonBackend Create method to delete pictures of people who left

...nd.PictureService/Phonebook.Backend.PictureService/Controllers/EmployeePicturesController.cs

Create method to get People from PersonBackend Create method to delete pictures of people who left

…ms-MMS/phonebook into feat/add-picture-service

GentleJames · 2019-08-26T08:08:14Z

Ready for review

DanielHabenicht · 2019-08-26T08:34:03Z

merge?

...Phonebook.Backend.PictureService/Phonebook.Backend.PictureService/ConfigureSwaggerOptions.cs

...nd/Phonebook.Backend.PictureService/Phonebook.Backend.PictureService/Helpers/HelpersThing.cs

DanielHabenicht · 2019-08-26T08:43:39Z

Phonebook.Backend/Phonebook.Backend.PictureService/Phonebook.Backend.PictureService/Startup.cs

+                options.GroupNameFormat = "'v'VVV";
+                // note: this option is only necessary when versioning by url segment. the SubstitutionFormat
+                // can also be used to control the format of the API version in route templates
+                options.SubstituteApiVersionInUrl = true;


Please do not version in the URL. We can have a debate if you want to :)

I would prefer query string or Header based versioning

thats the configuration for the Api Explorer. Not for the normal api endpoints. It would very helpful if we can create an "api" route path to make the differenz more clear. Because if you call:

users/whoami

you can do ?api-version=2.0.

But if you do the same on swagger it will show version 1. Because swagger works with another behavior without make it clear by the path. And this setting isn't very good documented. It does not a difference at all if you change the value from true to false. So maybe we must create an documentation issue in the apiExplorer project.

So currently there is no plan to change this line, if we doesn't know what is does.

Phonebook.Backend/Phonebook.Backend.PictureService/Phonebook.Backend.PictureService/Startup.cs

DanielHabenicht · 2019-08-26T08:49:21Z

Please add a secure by default approach for authentication.

@GentleJames you can try to set up a build if you want.

.azure/pipelines/pr/Phonebook.Backend.PictureService.pr.yml

paule96 · 2019-08-27T07:17:09Z

Please add a secure by default approach for authentication.
@GentleJames you can try to set up a build if you want.

This is solved ;)

…ist of valid content types, removed unnecessary comments in startup and added trigger paths to the backend build

.azure/pipelines/pr/Phonebook.Backend.PictureService.pr.yml

...PictureService/Phonebook.Backend.PictureService/Configuration/PictureServiceConfiguration.cs

Co-Authored-By: DanielHabenicht <[email protected]>

paule96 · 2019-09-01T14:52:06Z

I have removed @GentleJames from the contributors because he leave the company. So @GentleJames you must fork this repo to contribute again. That's the only thing that has changed for you.

P.S.: I will now finishing this PR. Thanks for your help!

- rename to ImageHelperFuncitons - add documentation about the functionalitiy - centralize some logic.

DanielHabenicht · 2019-11-29T14:35:28Z

what is holding us up here? @paule96

Authorization? (But only if it is run inside of Kubernetes)
Storing the images in Kubernetes

As both have to do with making the pictures service kubernetes ready I would like to merge this PR and make a new one for the other changes

DanielHabenicht · 2020-03-09T19:40:54Z

@paule96 ping

.azure/pipelines/pr/Phonebook.Backend.PictureService.pr.yml

mmsgithub-ci · 2020-03-09T19:58:03Z

Preview Environment ready at https://pr-161.demo-phonebook.me

DanielHabenicht · 2020-03-19T16:09:11Z

@Zeroks77 you are still welcome to finish this :)

…rvice

mmsgithub-ci · 2020-04-11T16:25:20Z

Preview Environment ready at https://pr-161.demo-phonebook.me

- also remove auth for now - also remove IIS integration for ever

mmsgithub-ci · 2020-04-11T19:27:08Z

Preview Environment ready at https://pr-161.demo-phonebook.me

mmsgithub-ci · 2020-04-11T19:42:31Z

Preview Environment ready at https://pr-161.demo-phonebook.me

paule96 · 2020-04-11T19:47:01Z

so I have start the basic implementation of the new auth. I test this if I'm back at work.

I late add the same anonymos stuff from the people soft backend.

mmsgithub-ci · 2020-04-11T19:50:24Z

Preview Environment ready at https://pr-161.demo-phonebook.me

hit always save!

mmsgithub-ci · 2020-04-12T12:28:02Z

Preview Environment ready at https://pr-161.demo-phonebook.me

DanielHabenicht added 2 commits August 9, 2019 09:42

Add Picture Service Code from Internal

3d96327

Make settings configurable in appsettings

82d3dbb

DanielHabenicht requested a review from paule96 August 12, 2019 11:47

DanielHabenicht added the chore Work that does not create value for the user, but is needed for the project to work. label Aug 12, 2019

DanielHabenicht added this to the New backend for Phonebook milestone Aug 12, 2019

paule96 requested changes Aug 12, 2019

View reviewed changes

DanielHabenicht commented Aug 15, 2019

View reviewed changes

...nd.PictureService/Phonebook.Backend.PictureService/Controllers/EmployeePicturesController.cs Show resolved Hide resolved

Christoph James Geisberger and others added 3 commits August 20, 2019 10:05

add wwwroot to git history

0b19553

Add backend to the workspace folders.

75ea5a3

- and add spellchecker to recommended extensions

Refactored PurgeTask

9b543ff

Create method to get People from PersonBackend Create method to delete pictures of people who left

kirkone reviewed Aug 20, 2019

View reviewed changes

...nd.PictureService/Phonebook.Backend.PictureService/Controllers/EmployeePicturesController.cs Outdated Show resolved Hide resolved

...nd.PictureService/Phonebook.Backend.PictureService/Controllers/EmployeePicturesController.cs Outdated Show resolved Hide resolved

GentleJames added 4 commits August 21, 2019 16:09

Refactored PurgeTask

891d119

Create method to get People from PersonBackend Create method to delete pictures of people who left

Merge branch 'feat/add-picture-service' of https://github.com/T-Syste…

164eb40

…ms-MMS/phonebook into feat/add-picture-service

Created List for valid content types and refactored a bit

81ddcc7

Lists all support mime types now in the error message

4350bd0

DanielHabenicht commented Aug 26, 2019

View reviewed changes

Build definition for PictureService

15a6dc5

DanielHabenicht commented Aug 26, 2019

View reviewed changes

.azure/pipelines/pr/Phonebook.Backend.PictureService.pr.yml Show resolved Hide resolved

GentleJames added 2 commits August 28, 2019 10:37

Changed license link, listed more common content types first in the l…

93121cc

…ist of valid content types, removed unnecessary comments in startup and added trigger paths to the backend build

Replaced a comment to a more fitting place

3d7b94f

DanielHabenicht commented Aug 28, 2019

View reviewed changes

.azure/pipelines/pr/Phonebook.Backend.PictureService.pr.yml Outdated Show resolved Hide resolved

...PictureService/Phonebook.Backend.PictureService/Configuration/PictureServiceConfiguration.cs Outdated Show resolved Hide resolved

Replaced wrong name

6e6af4b

Unnecessary comment

e594714

Co-Authored-By: DanielHabenicht <[email protected]>

refactor helperthings

ec1d6c1

- rename to ImageHelperFuncitons - add documentation about the functionalitiy - centralize some logic.

paule96 self-assigned this Sep 1, 2019

add IIS errors and IIS support

93cf6a5

DanielHabenicht requested a review from paule96 November 29, 2019 16:32

Merge branch 'master' into feat/add-picture-service

a5942c9

DanielHabenicht commented Mar 9, 2020

View reviewed changes

.azure/pipelines/pr/Phonebook.Backend.PictureService.pr.yml Outdated Show resolved Hide resolved

Update .azure/pipelines/pr/Phonebook.Backend.PictureService.pr.yml

b643243

Merge remote-tracking branch 'origin/master' into feat/add-picture-se…

0f434a6

…rvice

paule96 added 2 commits April 11, 2020 21:18

update to 3.1 dotnet and dependencies

d270b91

- also remove auth for now - also remove IIS integration for ever

remove the iis check from peoplesoft!

0b03465

paule96 added 4 commits April 11, 2020 21:34

use authorization again

bd44672

revert old changes

86fc60f

revert old changes

72a7727

remove old work

4588904

add ws federation as nuget ref 🙄

5789240

hit always save!

paule96 mentioned this pull request Dec 10, 2020

Change the message box for uploading pictures, because we want use the pictures in many systems #770

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feat/add picture service #161

Feat/add picture service #161

DanielHabenicht commented Aug 12, 2019 •

edited

Loading

DanielHabenicht commented Aug 12, 2019

DanielHabenicht commented Aug 12, 2019

GentleJames commented Aug 26, 2019

DanielHabenicht commented Aug 26, 2019

DanielHabenicht Aug 26, 2019

DanielHabenicht Aug 26, 2019

paule96 Sep 1, 2019

DanielHabenicht commented Aug 26, 2019

paule96 commented Aug 27, 2019

paule96 commented Sep 1, 2019 •

edited

Loading

DanielHabenicht commented Nov 29, 2019

DanielHabenicht commented Mar 9, 2020

mmsgithub-ci commented Mar 9, 2020

DanielHabenicht commented Mar 19, 2020

mmsgithub-ci commented Apr 11, 2020

mmsgithub-ci commented Apr 11, 2020

mmsgithub-ci commented Apr 11, 2020

paule96 commented Apr 11, 2020

mmsgithub-ci commented Apr 11, 2020

mmsgithub-ci commented Apr 12, 2020

Feat/add picture service #161

Are you sure you want to change the base?

Feat/add picture service #161

Conversation

DanielHabenicht commented Aug 12, 2019 • edited Loading

DanielHabenicht commented Aug 12, 2019

DanielHabenicht commented Aug 12, 2019

GentleJames commented Aug 26, 2019

DanielHabenicht commented Aug 26, 2019

DanielHabenicht Aug 26, 2019

Choose a reason for hiding this comment

DanielHabenicht Aug 26, 2019

Choose a reason for hiding this comment

paule96 Sep 1, 2019

Choose a reason for hiding this comment

DanielHabenicht commented Aug 26, 2019

paule96 commented Aug 27, 2019

paule96 commented Sep 1, 2019 • edited Loading

DanielHabenicht commented Nov 29, 2019

DanielHabenicht commented Mar 9, 2020

mmsgithub-ci commented Mar 9, 2020

DanielHabenicht commented Mar 19, 2020

mmsgithub-ci commented Apr 11, 2020

mmsgithub-ci commented Apr 11, 2020

mmsgithub-ci commented Apr 11, 2020

paule96 commented Apr 11, 2020

mmsgithub-ci commented Apr 11, 2020

mmsgithub-ci commented Apr 12, 2020

DanielHabenicht commented Aug 12, 2019 •

edited

Loading

paule96 commented Sep 1, 2019 •

edited

Loading