Feat/upgrade v0.50.1 sdk #4
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
C:Proto
Type: Build
C:CLI
Type: Tests
C:Types
C:Encoding
labels
RavenXce
requested changes
Jan 8, 2024
app/export.go
Outdated
| @@ -135,12 +144,27 @@ func (app *EthermintApp) prepForZeroHeightGenesis(ctx sdk.Context, jailAllowedAd | |||
| // reinitialize all validators | |||
| app.StakingKeeper.IterateValidators(ctx, func(_ int64, val stakingtypes.ValidatorI) (stop bool) { | |||
| // donate any unwithdrawn outstanding reward fraction tokens to the community pool | |||
| scraps := app.DistrKeeper.GetValidatorOutstandingRewardsCoins(ctx, val.GetOperator()) | |||
| feePool := app.DistrKeeper.GetFeePool(ctx) | |||
| valBz, err := app.StakingKeeper.ValidatorAddressCodec().StringToBytes((val.GetOperator())) | |||
x/evm/keeper/utils.go
Outdated
| return common.Address{}, errorsmod.Wrapf( | ||
| stakingtypes.ErrNoValidatorFound, | ||
| "failed to retrieve validator from block proposer address %s", | ||
| proposerAddress.String(), | ||
| ) | ||
| } | ||
| valBz, err := k.stakingKeeper.ValidatorAddressCodec().StringToBytes((validator.GetOperator())) |
x/feemarket/keeper/keeper_test.go
Outdated
| require.NoError(t, err) | ||
| appStakingKeeper := suite.app.StakingKeeper | ||
| validator = stakingkeeper.TestingUpdateValidator(&appStakingKeeper, suite.ctx, validator, true) | ||
| err = suite.app.StakingKeeper.Hooks().AfterValidatorCreated(suite.ctx, validator.GetOperator()) | ||
| valBz, err := suite.app.StakingKeeper.ValidatorAddressCodec().StringToBytes((validator.GetOperator())) |
…sulting in evm chain id not set on upgrade
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
key changes:
msg.GetSigners()is being deprecated and each message must explicitly declare which field within its struc, will be the signer field, in their relevanttx.protofiles refactor!: deprecate sdk.Msg.GetSigners cosmos/cosmos-sdk#15284msgEthereumTxrequires theirfromfield to be blank, a customGetSigner func is implemented for this msg, to bypass the new signer check 566bd45