Add network fees and transfer options config #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarah-thong
reviewed
Jul 21, 2023
| "usdc": 1, | ||
| "eth": 2 | ||
| } | ||
| } |
There was a problem hiding this comment.
Heyyo, for this PR:
-
You may need to add struct validation into
config.schema.jsonlike the rest of the fields.
Can check out how it's done here -
Do update the
README.mddocument with the fields that you added. -
Do update JSON Data Structure section under
.github/markets/pr_template.mdwith the definitions of the 2 new fields. -
Under
scripts/check_configs.ts, think it would be good to add code to validate the 2 new fields:
transfer_options- Whether or not the blockchain names (i.e. Cosmos Hub/Zilliqa) are valid bridges listed under
BridgeAllRPC call
- Whether or not the blockchain names (i.e. Cosmos Hub/Zilliqa) are valid bridges listed under
network_fees- Whether or not the denoms listed (i.e. swth/usdc) are valid denoms listed under
MinGasPriceAllRPC call
- Whether or not the denoms listed (i.e. swth/usdc) are valid denoms listed under
configs/mainnet.json
Outdated
| "bnb.1.6.773edb": 12, | ||
| "usdc.1.6.53ff75": 13, | ||
| "busd.1.6.754a80": 14, | ||
| "cgt/1": 15, |
There was a problem hiding this comment.
Suggestion: Think it would be good to bump up cgt/1 to above USC as it is a Carbon token and possibly the token with the most quantity (auto-conversion in 1:1 ratio).
… RPC call results
sarah-thong
approved these changes
Aug 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.