-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added @putmapping in FileStorageController class and updateFiles() FileStorageService class to updating file on Minio server #212
Conversation
… FileStorageService class to edit the document contents and updating edited file on Minio.
java/registry/src/main/java/dev/sunbirdrc/registry/controller/FileStorageController.java
Outdated
Show resolved
Hide resolved
java/registry/src/main/java/dev/sunbirdrc/registry/controller/FileStorageController.java
Outdated
Show resolved
Hide resolved
java/registry/src/main/java/dev/sunbirdrc/registry/service/FileStorageService.java
Outdated
Show resolved
Hide resolved
java/registry/src/main/java/dev/sunbirdrc/registry/service/FileStorageService.java
Outdated
Show resolved
Hide resolved
java/registry/src/main/java/dev/sunbirdrc/registry/service/FileStorageService.java
Outdated
Show resolved
Hide resolved
java/registry/src/main/java/dev/sunbirdrc/registry/service/FileStorageService.java
Outdated
Show resolved
Hide resolved
… FileStorageService class to edit the document contents and updating edited file on Minio.
java/registry/src/main/java/dev/sunbirdrc/registry/service/FileStorageService.java
Outdated
Show resolved
Hide resolved
java/registry/src/main/java/dev/sunbirdrc/registry/service/FileStorageService.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resolve conflicts
…Updated # Conflicts: # java/pojos/src/main/java/dev/sunbirdrc/pojos/Response.java # java/registry/src/main/java/dev/sunbirdrc/registry/controller/RegistryController.java # java/registry/src/main/java/dev/sunbirdrc/registry/controller/RegistryEntityController.java # java/registry/src/main/java/dev/sunbirdrc/registry/helper/RegistryHelper.java # java/registry/src/main/java/dev/sunbirdrc/registry/model/EventConfig.java # java/registry/src/main/java/dev/sunbirdrc/registry/model/EventType.java # java/registry/src/main/java/dev/sunbirdrc/registry/model/NotificationTemplates.java # java/registry/src/main/java/dev/sunbirdrc/registry/model/event/Actor.java # java/registry/src/main/java/dev/sunbirdrc/registry/model/event/Event.java # java/registry/src/main/java/dev/sunbirdrc/registry/model/event/TelemetryObject.java # java/registry/src/main/java/dev/sunbirdrc/registry/service/EntityTransformer.java # java/registry/src/main/java/dev/sunbirdrc/registry/service/IEventService.java # java/registry/src/main/java/dev/sunbirdrc/registry/service/RegistryService.java # java/registry/src/main/java/dev/sunbirdrc/registry/service/impl/RegistryServiceImpl.java # java/registry/src/main/java/dev/sunbirdrc/registry/service/mask/EmitStrategyFactory.java # java/registry/src/main/java/dev/sunbirdrc/registry/service/mask/HashMaskEmitStrategy.java # java/registry/src/main/java/dev/sunbirdrc/registry/service/mask/IEmitStrategy.java # java/registry/src/main/java/dev/sunbirdrc/registry/util/OSSchemaConfiguration.java
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please resolve all the comments and also add unit and e2e tests
java/elastic-search/src/main/java/dev/sunbirdrc/elastic/ESMessage.java
Outdated
Show resolved
Hide resolved
java/registry/src/main/java/dev/sunbirdrc/registry/controller/RegistryController.java
Outdated
Show resolved
Hide resolved
java/registry/src/main/java/dev/sunbirdrc/registry/dao/RegistryDaoImpl.java
Outdated
Show resolved
Hide resolved
java/sunbirdrc-actors/src/main/java/dev/sunbirdrc/actors/ElasticSearchActor.java
Outdated
Show resolved
Hide resolved
@holashchand please review, add whatever is missing and close this please. |
Closing since it contains irrelevant changes |
… FileStorageService class to edit the document contents and updating edited file on Minio.