feat: reload current asset list on nav tab click #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Milouu
force-pushed
the
feat/reload-on-tab-click
branch
2 times, most recently
from
ae405ef
to
bfc073a
Compare
FL-515 Refresh by clicking on the page
Context and user need: As a user I feel like when I click on "Compute plans" while already on the page it should reload it. Even though the Refresh button exist. If this seems like a good idea it could be broaden to the other pages. Functional spec: Technical spec: Acceptance criteria: Clicking on "Compute plans" should reload the page |
Milouu
force-pushed
the
feat/reload-on-tab-click
branch
2 times, most recently
from
30cf6a1
to
cf06e2f
Compare
Milouu
force-pushed
the
feat/reload-on-tab-click
branch
2 times, most recently
from
b72934d
to
c726923
Compare
Signed-off-by: Milouu <[email protected]>
Milouu
force-pushed
the
feat/reload-on-tab-click
branch
from
c726923
to
699533b
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently clicking on the navigation tab that is already active does nothing if the user is on page 1 with no filters. This behavior seems weird to some, so this PR aims to make the asset list reload instead.
Fixes FL-515