Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add more orchestrator documentation #346

Merged
merged 10 commits into from
Sep 1, 2023

Conversation

RomainGoussault
Copy link
Contributor

Signed-off-by: Romain Goussault [email protected]

Copy link
Member

@ThibaultFy ThibaultFy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestion and the blank background issue.

But love this new orc explanation thanks !

docs/source/documentation/orchestrator/index.rst Outdated Show resolved Hide resolved
docs/source/documentation/orchestrator/index.rst Outdated Show resolved Hide resolved
docs/source/documentation/orchestrator/index.rst Outdated Show resolved Hide resolved
Signed-off-by: Romain Goussault <[email protected]>
Copy link
Member

@ThibaultFy ThibaultFy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DCO fix a LGTM :)

Copy link
Contributor

@guilhem-barthes guilhem-barthes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work, made some comments feel free to disregard them!

docs/source/documentation/orchestrator/index.rst Outdated Show resolved Hide resolved

Distributed orchestration enables trustless verification of the integrity of assets (functions, model, data), but it requires connections between organizations, and introduces a network overhead. It's not possible to upgrade a Substra network when using distributed orchestration.

On the other hand, centralized orchestration requires trust in the central server, but it is more efficient, faster and easier to deploy and maintain.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure that the meaning of efficient is straightforward in this case

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed it.


On the other hand, centralized orchestration requires trust in the central server, but it is more efficient, faster and easier to deploy and maintain.

As long as you trust whomever is operating the orchestrator DB not to tamper with it, both modes offer the same level of guarantees. The decentralized mode has nice theoretical guarantees, but the network overhead is very significant, and has a lot of operational drawbacks. That is why, the vast majority (if not all) of the Substra deployments are using the centralized orchestration system as it is easier to operate and faster. However, the distributed orchestration is still maintained.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is why, the vast majority (if not all) of the Substra deployments

Should we emphazise that is the current situation but historically it may have been different ? (i.e. That is why, the vast majority (if not all) of the current Substra deployments)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agree, added

RomainGoussault and others added 2 commits September 1, 2023 10:53
Co-authored-by: Guilhem Barthés <[email protected]>
Signed-off-by: Romain Goussault <[email protected]>
@RomainGoussault RomainGoussault merged commit 5ad7838 into main Sep 1, 2023
2 checks passed
@RomainGoussault RomainGoussault deleted the docs--more-docs-on-orchestrator branch September 1, 2023 09:17
@Milouu Milouu mentioned this pull request Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants