Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: how to use user require approval #329

Merged
merged 2 commits into from
Jul 24, 2023

Conversation

IC-1101asterisk
Copy link
Contributor

@IC-1101asterisk IC-1101asterisk commented Jul 13, 2023

Adding some text in how-to to explain how the new feature flag works.

Fixes FL-989

Signed-off-by: Olivier Léobal <[email protected]>
@oleobal oleobal force-pushed the feat-user-awaiting-approval branch from 04365dc to 1017268 Compare July 20, 2023 13:36
@linear
Copy link

linear bot commented Jul 20, 2023

FL-989 SSO v3: Admin should validate user

See Notion document: https://www.notion.so/owkin-fdn/SSO-v3-99a6bacb57cd4407a5e4537ae018e469

To try and better specify this feature :

  • there should be a new type of users "shadow users"
  • shadow users can connect but will be met with a page telling them to wait for approval
  • they have to contact admin on their own
  • admin will need a new page with shadow users to approve them (or on the already existing page user but what if tons of shadow users ?)

- this should be a new model

- new page "unregistered" users

- new "blank" page => go contact your admin user by slack or email

- SSO system handles differently depending on registered or un registered user

@IC-1101asterisk IC-1101asterisk merged commit e3b796b into main Jul 24, 2023
2 checks passed
@IC-1101asterisk IC-1101asterisk deleted the feat-user-awaiting-approval branch July 24, 2023 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants