Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

๐Ÿ‘ท CI Workflow #12

Merged
merged 12 commits into from
Sep 21, 2024
Merged

๐Ÿ‘ท CI Workflow #12

merged 12 commits into from
Sep 21, 2024

Conversation

waterfogSW
Copy link
Member

@waterfogSW waterfogSW commented Sep 21, 2024

Summary by CodeRabbit

  • ์ƒˆ๋กœ์šด ๊ธฐ๋Šฅ

    • GitHub Actions๋ฅผ ํ†ตํ•œ CI ํ”„๋กœ์„ธ์Šค๋ฅผ ์ž๋™ํ™”ํ•˜๋Š” ์ƒˆ๋กœ์šด ์›Œํฌํ”Œ๋กœ์šฐ ์ถ”๊ฐ€.
    • Docker ์ด๋ฏธ์ง€๋ฅผ ๋นŒ๋“œํ•˜๊ณ  AWS ECR์— ํ‘ธ์‹œํ•˜๋Š” ๊ธฐ๋Šฅ ์ถ”๊ฐ€.
  • ์žก์ผ

    • Jib ํ”Œ๋Ÿฌ๊ทธ์ธ ๋ฐ ์˜์กด์„ฑ ์ถ”๊ฐ€.

Copy link

coderabbitai bot commented Sep 21, 2024

Warning

Rate limit exceeded

@waterfogSW has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 3 minutes and 46 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

Commits

Files that changed from the base of the PR and between 3d99a77 and 9340096.

Walkthrough

์ด ๋ณ€๊ฒฝ ์‚ฌํ•ญ์€ GitHub Actions ์›Œํฌํ”Œ๋กœ์šฐ ํŒŒ์ผ ci.yaml์„ ์ถ”๊ฐ€ํ•˜์—ฌ ํ”„๋กœ์ ํŠธ์˜ ์ง€์†์ ์ธ ํ†ตํ•ฉ ํ”„๋กœ์„ธ์Šค๋ฅผ ์ž๋™ํ™”ํ•˜๋Š” ๋‚ด์šฉ์„ ํฌํ•จํ•ฉ๋‹ˆ๋‹ค. ์ด ์›Œํฌํ”Œ๋กœ์šฐ๋Š” main ๋ธŒ๋žœ์น˜์— ๋Œ€ํ•œ ํ‘ธ์‹œ ๋ฐ ํ’€ ๋ฆฌํ€˜์ŠคํŠธ์— ์˜ํ•ด ํŠธ๋ฆฌ๊ฑฐ๋˜๋ฉฐ, AWS ์ง€์—ญ ๋ฐ ECR ๋ฆฌํฌ์ง€ํ† ๋ฆฌ ์ด๋ฆ„์— ๋Œ€ํ•œ ํ™˜๊ฒฝ ๋ณ€์ˆ˜๋ฅผ ์„ค์ •ํ•ฉ๋‹ˆ๋‹ค. ๋˜ํ•œ Gradle ๋นŒ๋“œ ๊ตฌ์„ฑ์— Jib ํ”Œ๋Ÿฌ๊ทธ์ธ์„ ์ถ”๊ฐ€ํ•˜๊ณ , Docker ์ด๋ฏธ์ง€๋ฅผ ๋นŒ๋“œํ•˜์—ฌ AWS ECR์— ํ‘ธ์‹œํ•˜๋Š” ์„ค์ •์„ ํฌํ•จํ•˜๊ณ  ์žˆ์Šต๋‹ˆ๋‹ค.

Changes

ํŒŒ์ผ ๊ฒฝ๋กœ ๋ณ€๊ฒฝ ์š”์•ฝ
.github/workflows/ci.yaml CI ํ”„๋กœ์„ธ์Šค๋ฅผ ์ž๋™ํ™”ํ•˜๊ธฐ ์œ„ํ•œ ์ƒˆ๋กœ์šด GitHub Actions ์›Œํฌํ”Œ๋กœ์šฐ ํŒŒ์ผ ์ถ”๊ฐ€.
bootstrap/api/build.gradle.kts Jib ํ”Œ๋Ÿฌ๊ทธ์ธ์„ ์ถ”๊ฐ€ํ•˜๊ณ , Docker ์ด๋ฏธ์ง€๋ฅผ ๋นŒ๋“œํ•˜๊ธฐ ์œ„ํ•œ ๊ธฐ๋ณธ ์ด๋ฏธ์ง€ ์„ค์ •.
gradle/libs.versions.toml Jib ๋ผ์ด๋ธŒ๋Ÿฌ๋ฆฌ ์˜์กด์„ฑ์„ ์ถ”๊ฐ€ํ•˜๊ณ  ๋ฒ„์ „ 3.4.3์œผ๋กœ ์„ค์ •.

Possibly related PRs

  • ๐Ÿ‘ท Sonar Cloud ์ถ”๊ฐ€ย #6: ๋‘ PR ๋ชจ๋‘ Docker ์ด๋ฏธ์ง€ ๋นŒ๋“œ ๋ฐ Jib ํ”Œ๋Ÿฌ๊ทธ์ธ ํ†ตํ•ฉ๊ณผ ๊ด€๋ จ๋œ build.gradle.kts ํŒŒ์ผ์˜ ์ˆ˜์ •์ด ํฌํ•จ๋˜์–ด ์žˆ์–ด CI/CD ํ”„๋กœ์„ธ์Šค์™€์˜ ์ง์ ‘์ ์ธ ์—ฐ๊ฒฐ์„ ๋‚˜ํƒ€๋ƒ…๋‹ˆ๋‹ค.

Suggested reviewers

  • dojinyou

๐Ÿ‡ ์ƒˆ๋กœ์šด ์›Œํฌํ”Œ๋กœ์šฐ๊ฐ€ ๋„์ฐฉํ–ˆ์–ด์š”,
CI๊ฐ€ ์ž๋™์œผ๋กœ ๋น›๋‚˜๊ณ ,
Jib๊ณผ ํ•จ๊ป˜ ์ด๋ฏธ์ง€๋ฅผ ๋งŒ๋“ค๊ณ ,
ECR๋กœ ํ‘ธ์‹œํ•˜๋ฉฐ ๋›ฐ์–ด๋†€์•„์š”!
Rabbit์˜ ๊ธฐ์จ, ํ•จ๊ป˜ ํ•˜์„ธ์š”! ๐Ÿฅ•โœจ


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    -- I pushed a fix in commit <commit_id>, please review it.
    -- Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    -- @coderabbitai generate unit testing code for this file.
    -- @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    -- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    -- @coderabbitai read src/utils.ts and generate unit testing code.
    -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Outside diff range and nitpick comments (2)
.github/workflows/ci.yaml (1)

33-38: AWS ์ž๊ฒฉ ์ฆ๋ช… ๊ตฌ์„ฑ์„ ๊ฐœ์„ ํ•ด ๋ณด๋Š” ๊ฒƒ์€ ์–ด๋–จ๊นŒ์š”?

AWS ์ž๊ฒฉ ์ฆ๋ช…์„ ์ €์žฅํ•˜๊ธฐ ์œ„ํ•ด secrets๋ฅผ ์‚ฌ์šฉํ•œ ๊ฒƒ์€ ์ข‹์Šต๋‹ˆ๋‹ค. ํ•˜์ง€๋งŒ AWS ๋ฆฌ์ „์„ ์›Œํฌํ”Œ๋กœ์šฐ ํŒŒ์ผ์— ํ•˜๋“œ์ฝ”๋”ฉํ•˜๋Š” ๊ฒƒ์€ ๋‚˜์ค‘์— ๋ฆฌ์ „์„ ๋ณ€๊ฒฝํ•˜๊ธฐ ์–ด๋ ต๊ฒŒ ๋งŒ๋“ค ์ˆ˜ ์žˆ์–ด์š”.

AWS ๋ฆฌ์ „์— ํ™˜๊ฒฝ ๋ณ€์ˆ˜๋ฅผ ์‚ฌ์šฉํ•˜๋Š” ๊ฒƒ์„ ๊ณ ๋ คํ•ด ๋ณด์„ธ์š”. ๊ทธ๋Ÿฌ๋ฉด ๋‚˜์ค‘์— ๋ฆฌ์ „์„ ๋” ์‰ฝ๊ฒŒ ๋ณ€๊ฒฝํ•  ์ˆ˜ ์žˆ์Šต๋‹ˆ๋‹ค.

gradle/libs.versions.toml (1)

98-98: ์˜์กด์„ฑ ์„ ์–ธ์ด ์˜ฌ๋ฐ”๋ฆ…๋‹ˆ๋‹ค.

jib ๋ผ์ด๋ธŒ๋Ÿฌ๋ฆฌ์— ๋Œ€ํ•œ ์˜์กด์„ฑ ์„ ์–ธ์ด ์˜ฌ๋ฐ”๋ฅด๊ฒŒ ์ž‘์„ฑ๋˜์—ˆ์Šต๋‹ˆ๋‹ค. ์ด์ „์— ์ถ”๊ฐ€๋œ jib ๋ฒ„์ „์„ ์ฐธ์กฐํ•˜๊ณ  ์žˆ์Šต๋‹ˆ๋‹ค.

๋นŒ๋“œ ๊ตฌ์„ฑ๊ณผ ๋ฌธ์„œ ์—…๋ฐ์ดํŠธ๋ฅผ ์žŠ์ง€ ๋งˆ์„ธ์š”.

jib ์˜์กด์„ฑ ์ถ”๊ฐ€๋กœ ์ธํ•ด ๋นŒ๋“œ ๊ตฌ์„ฑ๊ณผ ๋ฌธ์„œ๋ฅผ ์—…๋ฐ์ดํŠธํ•ด์•ผ ํ•  ์ˆ˜๋„ ์žˆ์Šต๋‹ˆ๋‹ค. ํ•„์š”ํ•œ ๊ฒฝ์šฐ ์—…๋ฐ์ดํŠธํ•˜๋Š” ๊ฒƒ์„ ์žŠ์ง€ ๋งˆ์„ธ์š”.

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between dfc2cc0 and 7f11f52.

Files selected for processing (3)
  • .github/workflows/ci.yaml (1 hunks)
  • bootstrap/api/build.gradle.kts (2 hunks)
  • gradle/libs.versions.toml (2 hunks)
Additional context used
actionlint
.github/workflows/ci.yaml

48-48: shellcheck reported issue in this script: SC2086:info:2:18: Double quote to prevent globbing and word splitting

(shellcheck)


48-48: shellcheck reported issue in this script: SC2086:info:2:32: Double quote to prevent globbing and word splitting

(shellcheck)


48-48: shellcheck reported issue in this script: SC2086:info:2:48: Double quote to prevent globbing and word splitting

(shellcheck)

Additional comments not posted (7)
bootstrap/api/build.gradle.kts (2)

5-5: ์ž˜ ๋˜์—ˆ์Šต๋‹ˆ๋‹ค!

์• ํ”Œ๋ฆฌ์ผ€์ด์…˜์„ ์ปจํ…Œ์ด๋„ˆํ™”ํ•˜๊ธฐ ์œ„ํ•ด Jib ํ”Œ๋Ÿฌ๊ทธ์ธ์„ ์ถ”๊ฐ€ํ•˜๋Š” ๊ฒƒ์€ ์ข‹์€ ๋ฐฉ๋ฒ•์ž…๋‹ˆ๋‹ค. ๋˜ํ•œ ๋ฒ„์ „ ์นดํƒˆ๋กœ๊ทธ(libs.versions.jib)๋ฅผ ์‚ฌ์šฉํ•˜์—ฌ ํ”Œ๋Ÿฌ๊ทธ์ธ ๋ฒ„์ „์„ ๊ด€๋ฆฌํ•˜๋Š” ๊ฒƒ๋„ ๊ถŒ์žฅ๋˜๋Š” ์ ‘๊ทผ ๋ฐฉ์‹์ž…๋‹ˆ๋‹ค.


53-60: ๊ธฐ๋ฐ˜ ์ด๋ฏธ์ง€ ์„ค์ •์ด ์ž˜ ๋˜์—ˆ์Šต๋‹ˆ๋‹ค.

Jib ๊ตฌ์„ฑ์—์„œ ๊ธฐ๋ฐ˜ ์ด๋ฏธ์ง€๋ฅผ ์ง€์ •ํ•˜๋Š” ๊ฒƒ์€ ์ค‘์š”ํ•œ ๋ถ€๋ถ„์ž…๋‹ˆ๋‹ค. ์„ ํƒํ•œ ๊ธฐ๋ฐ˜ ์ด๋ฏธ์ง€๋Š” ๊ฒฝ๋Ÿ‰์˜ Alpine ๊ธฐ๋ฐ˜ OpenJDK ์ด๋ฏธ์ง€๋กœ, Java ์• ํ”Œ๋ฆฌ์ผ€์ด์…˜์— ์ ํ•ฉํ•œ ์„ ํƒ์œผ๋กœ ๋ณด์ž…๋‹ˆ๋‹ค. ๋˜ํ•œ ๊ธฐ๋ฐ˜ ์ด๋ฏธ์ง€ ๋ฒ„์ „์„ ํŠน์ • ํƒœ๊ทธ(21)๋กœ ๊ณ ์ •ํ•˜์—ฌ ์ผ๊ด€๋œ ๋นŒ๋“œ๋ฅผ ๋ณด์žฅํ•˜๊ณ  ์žˆ์Šต๋‹ˆ๋‹ค.

.github/workflows/ci.yaml (4)

20-24: JDK ์„ค์ •์ด ์˜ฌ๋ฐ”๋ฅธ ๊ฒƒ ๊ฐ™์Šต๋‹ˆ๋‹ค.

JDK 21์„ ์‚ฌ์šฉํ•˜๊ณ  ์ •ํ™•ํ•œ ๋ฒ„์ „์„ ์ง€์ •ํ•œ ๊ฒƒ์€ ์ข‹์€ ๋ฐฉ๋ฒ•์ž…๋‹ˆ๋‹ค. ๋‹ค๋งŒ Liberica ๋ฐฐํฌํŒ์„ ์„ ํƒํ•œ ์ด์œ ๊ฐ€ ๊ถ๊ธˆํ•ฉ๋‹ˆ๋‹ค. ์ด ์„ ํƒ์— ๋Œ€ํ•ด ์„ค๋ช…ํ•ด ์ฃผ์‹œ๊ฒ ์–ด์š”?


26-31: Gradle ํŒจํ‚ค์ง€ ์บ์‹ฑ ์„ค์ •์ด ์ ์ ˆํ•ด ๋ณด์ž…๋‹ˆ๋‹ค.

Gradle ํŒŒ์ผ์˜ ํ•ด์‹œ๋ฅผ ์บ์‹œ ํ‚ค์— ํฌํ•จ์‹œ์ผœ ์˜์กด์„ฑ์ด ๋ณ€๊ฒฝ๋˜๋ฉด ์บ์‹œ๊ฐ€ ๋ฌดํšจํ™”๋˜๋„๋ก ํ•œ ๊ฒƒ์ด ์ข‹๋„ค์š”. ์ด์ „ ์บ์‹œ๋กœ ํด๋ฐฑํ•  ์ˆ˜ ์žˆ๋„๋ก ๋ณต์› ํ‚ค๋ฅผ ์‚ฌ์šฉํ•œ ๊ฒƒ๋„ ์ž˜ ํ–ˆ์Šต๋‹ˆ๋‹ค.


40-42: Amazon ECR ๋กœ๊ทธ์ธ ์„ค์ •์ด ์ ์ ˆํ•ด ๋ณด์ž…๋‹ˆ๋‹ค.

๋‹ค์Œ ๋‹จ๊ณ„์—์„œ Docker ์ด๋ฏธ์ง€๋ฅผ ํ‘ธ์‹œํ•˜๋ ค๋ฉด ECR์— ๋กœ๊ทธ์ธํ•ด์•ผ ํ•˜์ฃ . ECR ๋กœ๊ทธ์ธ์„ ์ฒ˜๋ฆฌํ•˜๊ธฐ ์œ„ํ•ด ์•ก์…˜์„ ์‚ฌ์šฉํ•œ ๊ฒƒ์ด ์›Œํฌํ”Œ๋กœ์šฐ ํŒŒ์ผ์„ ๋‹จ์ˆœํ™”ํ•˜๋Š” ์ข‹์€ ๋ฐฉ๋ฒ•์ž…๋‹ˆ๋‹ค.


55-63: ์ด๋ฏธ์ง€ ์ •๋ณด ์ €์žฅ ๋ฐ ์•„ํ‹ฐํŒฉํŠธ ์—…๋กœ๋“œ ๋‹จ๊ณ„๊ฐ€ ์ ์ ˆํ•ด ๋ณด์ž…๋‹ˆ๋‹ค.

์ „์ฒด ์ด๋ฏธ์ง€ ์ด๋ฆ„๊ณผ ํƒœ๊ทธ๋ฅผ ํŒŒ์ผ๋กœ ์ €์žฅํ•˜๋ฉด ๋‹ค๋ฅธ ์ž‘์—…์ด๋‚˜ ๋‹จ๊ณ„์—์„œ ๋‚˜์ค‘์— ์ด ์ •๋ณด์— ์•ก์„ธ์Šคํ•  ์ˆ˜ ์žˆ๊ฒ ๋„ค์š”. ๊ทธ ํŒŒ์ผ์„ ์•„ํ‹ฐํŒฉํŠธ๋กœ ์—…๋กœ๋“œํ•˜๋ฉด ๋‹ค๋ฅธ ์ž‘์—…์ด๋‚˜ ์›Œํฌํ”Œ๋กœ์šฐ์—์„œ ๋‹ค์šด๋กœ๋“œํ•˜์—ฌ ์‚ฌ์šฉํ•  ์ˆ˜ ์žˆ๊ณ ์š”.

์ด๋Ÿฌํ•œ ๋‹จ๊ณ„๋Š” ๋ฐฐํฌํ•  ์ด๋ฏธ์ง€๋ฅผ ์•Œ์•„์•ผ ํ•˜๋Š” ์ž ์žฌ์  ๋ฐฐํฌ ์ž‘์—…์„ ์œ„ํ•œ ์ค€๋น„ ๊ฐ™์Šต๋‹ˆ๋‹ค. ์ „์ฒด์ ์œผ๋กœ ์ž˜ ์„ค๊ณ„๋œ ๊ฒƒ ๊ฐ™์•„์š”.

gradle/libs.versions.toml (1)

10-10: ์ข‹์•„ ๋ณด์ž…๋‹ˆ๋‹ค!

jib ๋ผ์ด๋ธŒ๋Ÿฌ๋ฆฌ์˜ ์ƒˆ๋กœ์šด ๋ฒ„์ „์„ ์ถ”๊ฐ€ํ•˜๋Š” ๊ฒƒ์€ ๋ฌธ์ œ๊ฐ€ ์—†์–ด ๋ณด์ž…๋‹ˆ๋‹ค.

.github/workflows/ci.yaml Outdated Show resolved Hide resolved
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 745ee06 and 3d99a77.

Files selected for processing (1)
  • .github/workflows/ci.yaml (1 hunks)
Additional context used
actionlint
.github/workflows/ci.yaml

68-68: shellcheck reported issue in this script: SC2046:warning:38:6: Quote this to prevent word splitting

(shellcheck)


68-68: shellcheck reported issue in this script: SC2086:info:44:32: Double quote to prevent globbing and word splitting

(shellcheck)

Additional comments not posted (4)
.github/workflows/ci.yaml (4)

120-124: ๊ณผ๊ฑฐ ๋ฆฌ๋ทฐ ๋Œ“๊ธ€์ด ๋ฐ˜์˜๋˜์—ˆ์Šต๋‹ˆ๋‹ค.

Jib ๋ช…๋ น์—์„œ ๋ณ€์ˆ˜๋ฅผ ํฐ๋”ฐ์˜ดํ‘œ๋กœ ๋ฌถ๋Š” ๊ฒƒ์— ๋Œ€ํ•œ ๊ณผ๊ฑฐ ๋ฆฌ๋ทฐ ๋Œ“๊ธ€์ด ์ž˜ ๋ฐ˜์˜๋˜์—ˆ๋„ค์š”. ์ด์ œ ๊ธ€๋กœ๋น™๊ณผ ๋‹จ์–ด ๋ถ„ํ•  ๋ฌธ์ œ๊ฐ€ ํ•ด๊ฒฐ๋˜์—ˆ์Šต๋‹ˆ๋‹ค.


128-129: ์ข‹์•„์š”!

์ด์ „ ๋‹จ๊ณ„์—์„œ ์–ป์€ ์ด๋ฏธ์ง€ ๋ ˆ์ง€์ŠคํŠธ๋ฆฌ URL, ๋ฆฌํฌ์ง€ํ† ๋ฆฌ ์ด๋ฆ„, ์ƒ์„ฑ๋œ ๋ฒ„์ „ ํƒœ๊ทธ๋ฅผ ์‚ฌ์šฉํ•˜์—ฌ ์ „์ฒด ์ด๋ฏธ์ง€ ์ด๋ฆ„์„ ๊ตฌ์„ฑํ•˜๋Š” ๊ฒƒ์ด ์ข‹๋„ค์š”. ์ด๋ ‡๊ฒŒ ํ•˜๋ฉด ์ผ๊ด€์„ฑ์„ ์œ ์ง€ํ•  ์ˆ˜ ์žˆ์Šต๋‹ˆ๋‹ค.

๋˜ํ•œ ์ด๋ฏธ์ง€ ์ •๋ณด๋ฅผ ํŒŒ์ผ๋กœ ์ €์žฅํ•˜๋ฉด ํ›„์† ๋‹จ๊ณ„๋‚˜ ์ž‘์—…์—์„œ ์•„ํ‹ฐํŒฉํŠธ๋กœ ์‚ฌ์šฉํ•  ์ˆ˜ ์žˆ์–ด์„œ ์œ ์šฉํ•ด์š”.


132-136: ์ž˜ ํ–ˆ์–ด์š”!

image_info.txt ํŒŒ์ผ์„ "image-info"๋ผ๋Š” ์ด๋ฆ„์˜ ์•„ํ‹ฐํŒฉํŠธ๋กœ ์—…๋กœ๋“œํ•˜๋Š” ๊ฒƒ์€ ์•„์ฃผ ์ข‹์€ ๋ฐฉ๋ฒ•์ด์—์š”. ์ด๋ ‡๊ฒŒ ํ•˜๋ฉด ํ›„์† ์ž‘์—…์ด๋‚˜ ์›Œํฌํ”Œ๋กœ์šฐ์—์„œ ์ด ์ •๋ณด๋ฅผ ์‰ฝ๊ฒŒ ์‚ฌ์šฉํ•  ์ˆ˜ ์žˆ์Šต๋‹ˆ๋‹ค.

์•„ํ‹ฐํŒฉํŠธ ์ด๋ฆ„๋„ ๋ช…ํ™•ํ•˜๊ณ  ์„ค๋ช…์ด ์ž˜ ๋˜์–ด ์žˆ๋„ค์š”.


138-145: ํ›Œ๋ฅญํ•ด์š”!

์ƒ์„ฑ๋œ ๋ฒ„์ „์œผ๋กœ Git ํƒœ๊ทธ๋ฅผ ๋งŒ๋“œ๋Š” ๊ฒƒ์€ ๋ฒ„์ „ ๊ด€๋ฆฌ์™€ ๋ฆด๋ฆฌ์Šค ๊ด€๋ฆฌ๋ฅผ ์œ„ํ•œ ์•„์ฃผ ์ข‹์€ ๋ฐฉ๋ฒ•์ž…๋‹ˆ๋‹ค.

ํƒœ๊ทธ ์ƒ์„ฑ์„ ํŠน์ • ์ด๋ฒคํŠธ(์ˆ˜๋™ ๋””์ŠคํŒจ์น˜ ๋˜๋Š” main ๋ธŒ๋žœ์น˜ ํ‘ธ์‹œ)๋กœ ์ œํ•œํ•˜๋Š” ๊ฒƒ๋„ ํ˜„๋ช…ํ•œ ์„ ํƒ์ด์—์š”. ์ด๋ ‡๊ฒŒ ํ•˜๋ฉด ํ•„์š”ํ•  ๋•Œ๋งŒ ํƒœ๊ทธ๊ฐ€ ์ƒ์„ฑ๋˜๋ฏ€๋กœ ํƒœ๊ทธ ๊ด€๋ฆฌ๊ฐ€ ์ˆ˜์›”ํ•ด์ง‘๋‹ˆ๋‹ค.

์ƒ์„ฑ๋œ ํƒœ๊ทธ๋ฅผ ์›๊ฒฉ ๋ฆฌํฌ์ง€ํ† ๋ฆฌ์— ํ‘ธ์‹œํ•˜๋ฉด ๋‹ค๋ฅธ ์›Œํฌํ”Œ๋กœ์šฐ์™€ ์‚ฌ์šฉ์ž๋“ค๋„ ์ด ํƒœ๊ทธ๋ฅผ ์‚ฌ์šฉํ•  ์ˆ˜ ์žˆ๊ฒŒ ๋˜์ฃ .

.github/workflows/ci.yaml Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented Sep 21, 2024

@waterfogSW waterfogSW merged commit ba1ef3f into main Sep 21, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant