Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add adjustments for vcpkg #195

Closed
wants to merge 2 commits into from
Closed

Conversation

ngrodzitski
Copy link
Member

No description provided.

@eao197
Copy link
Member

eao197 commented Nov 10, 2023

I don't like very long names like "RESTINIO_DEPENDENCY_RESOLVE_HINT_FMT". It's almost impossible to write such a name by hand without a mistake.

Can we use something shorter? Like "RESTINIO_DEP_FMT" and "RESTINIO_DEP_LLHTTP" (with allowed values like "system", "find" and "local")?

@eao197
Copy link
Member

eao197 commented Nov 10, 2023

Short names are much better, thanks you!

But can we use "find" instead of "find_package"?
I can understand if we have to introduce another alternative like "find_dependency" in the near future and there will be significant distinction between "find_package" and "find_dependency". But if we have no such plans, may be just "find" is the best?

@ngrodzitski
Copy link
Member Author

ngrodzitski commented Nov 10, 2023

Short names are much better, thanks you!

But can we use "find" instead of "find_package"? I can understand if we have to introduce another alternative like "find_dependency" in the near future and there will be significant distinction between "find_package" and "find_dependency". But if we have no such plans, may be just "find" is the best?

Then I propose "package" as [system, local, package] looks more logical to me than [system, local, find]?

@eao197
Copy link
Member

eao197 commented Nov 11, 2023

Then I propose "package" as [system, local, package] looks more logical to me than [system, local, find]?

I'm afraid it would be hard to explain how "package" differs from "system" if a system package management is used for installing packages like "boost", "fmt" and "llhttp".

If you don't want to make another rename then I can do it.

@eao197
Copy link
Member

eao197 commented Nov 11, 2023

Another alternative to "package" and "find": "config".
So we can have: "system" (installed somewhere in the system by system package manager), "local" (present in the project's source tree) and "config" (the config has to be found via find_package).

@eao197
Copy link
Member

eao197 commented Nov 12, 2023

It's replaced by #196

@eao197 eao197 closed this Nov 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants